[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [patch] file:// link in mailreader
From:       Martin Koller <m.koller () surfeu ! at>
Date:       2008-03-24 10:28:01
Message-ID: 200803241128.02582.m.koller () surfeu ! at
[Download RAW message or body]

On Saturday 22 March 2008, Till Adam wrote:

> We'll discuss it, I'd like to think through the impliciations a bit.

Just another input:
smb:// is forwarded to file:// and smb:// links are already klickable

Also I forgot to add file:// in isEmptyUrl()
New patch attached.

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

["file-link.patch" (text/x-diff)]

Index: linklocator.cpp
===================================================================
--- linklocator.cpp	(revision 789445)
+++ linklocator.cpp	(working copy)
@@ -142,9 +142,9 @@
                        mText.mid(mPos, 6) == "smb://") ) ||
          (ch=='m' && mText.mid(mPos, 7) == "mailto:") ||
          (ch=='w' && mText.mid(mPos, 4) == "www.") ||
-         (ch=='f' && mText.mid(mPos, 4) == "ftp.") ||
+         (ch=='f' && ( mText.mid(mPos, 4) == "ftp.") ||
+                       mText.mid(mPos, 7) == "file://" ) ||
          (ch=='n' && mText.mid(mPos, 5) == "news:");
-         // note: no "file:" for security reasons
 }
 
 bool LinkLocator::isEmptyUrl(const QString& url)
@@ -153,6 +153,7 @@
          url == "http://" ||
          url == "https://" ||
          url == "fish://" ||
+         url == "file://" ||
          url == "ftp://" ||
          url == "ftps://" ||
          url == "sftp://" ||


_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]