From kde-pim  Fri Mar 14 20:41:26 2008
From: Thomas McGuire <Thomas.McGuire () gmx ! net>
Date: Fri, 14 Mar 2008 20:41:26 +0000
To: kde-pim
Subject: Re: [Kde-pim] [patch] KMail: fox for text codecs + questions on
Message-Id: <200803142141.36303.Thomas.McGuire () gmx ! net>
X-MARC-Message: https://marc.info/?l=kde-pim&m=120552736307026
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1261138727=="

--===============1261138727==
Content-Type: multipart/signed;
  boundary="nextPart4658724.YEmECVpFW7";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart4658724.YEmECVpFW7
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

On Friday 14 March 2008, Jaros=C5=82aw Staniek wrote:
> For review.
>
> 1. For creating emails use codec returned by KGlobal::locale()->encoding(=
),
> what on non-windows is equal to QTextCodec::codecForLocale() (see
> KLocalePrivate::initEncoding()).
> On windows QTextCodec::codecForLocale() returns "System", so we're using
> GetLocaleInfo() to get the actual CP system's charset.
>
> 2. A fix for japanese codec on Windows and Mac (just switches from
> shift-jis to jis7 in addition to the previous behaviour so would not break
> things), see the comment added in the code.

Disclaimer: I don't know much about encoding (I've only read the MIME RFCs=
=20
now).
I guess the patch is OK. The only problem I see is that networkCodec() is a=
lso=20
used to decode MIME messages without a specified charset. However, accordin=
g=20
to the RFC, we should use us-ascii for that. But this has always been the=20
case in KMail code, so I think it is no problem. I'm just wondering about t=
he=20
consequences of a changed networkCodec() here.
About the shift-jis/jis7 thing: You seem to know more about this than me, s=
o I=20
assume this is correct.

So please go ahead and commit the patch.

Regards,
Thomas


--nextPart4658724.YEmECVpFW7
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)

iD8DBQBH2uMAKglv3sO8a1MRArwOAKCr/SX0BjjjRrrSQK3/EDvWkA8LAACcD5gN
x8rs+E4kdr5RaZGyz6/Jqbo=
=YBFP
-----END PGP SIGNATURE-----

--nextPart4658724.YEmECVpFW7--

--===============1261138727==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============1261138727==--