--===============1784027078==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr"
Content-Disposition: inline


--PNTmBPCT7hxwcZjr
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 06, 2008 at 09:34:42PM +0100, Martin Koller wrote:
> Hello,
Hej Martin,

> But as the input is an unconverted string (at least after I changed some=
=20
> QTextString::setEncoding from UTF8 to Latin1), this must be the case.
> (And if it's not, the vcardparser would not work anyway, as a probably gi=
ven=20
> CHARSET could not be handled)
Ok, right.

> So the only problematic step might be this:
> -          vCardLine.setValue( value );
> +        } else {  // if charset not given, assume it's in UTF-8 (as used=
 in=20
> previous KDE versions)
> +            vCardLine.setValue( QString::fromUtf8( output ) );
>=20
> and if you really see this as needed, I could add the following workaroun=
d:
> Convert given QString to latin1(), convert back to QString, check if stil=
l=20
> equal with given string. If so, use "fromUtf8", else use given string.
Sounds like a performance bottleneck to me... let's omit it and wait
until somebody complains ;)

Ok, so the patch is fine, please commit.

Ciao,
Tobias
--=20
Separate politics from religion and economy!
The Council of the European Union is an undemocratic and illegal institutio=
n!

--PNTmBPCT7hxwcZjr
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHgUbtSvFUKpY6VLARAp2pAJ9VcJVJCxYBXd0tojpngxFt1H7FvQCfZt/f
Skx9nHfAP4iA9n74t2coK3k=
=c2Tz
-----END PGP SIGNATURE-----

--PNTmBPCT7hxwcZjr--

--===============1784027078==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============1784027078==--