[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [patch] vcard parsing in KDE3.5
From:       Tobias Koenig <tokoe () kde ! org>
Date:       2008-01-06 17:36:16
Message-ID: 20080106173616.GB3636 () ghostdog ! localnet
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sat, Jan 05, 2008 at 01:52:16PM +0100, Martin Koller wrote:
> Hi all,
Hej Martin,

> attached is a patch that corrects the vcard parsing bug (kdelibs/kabc) dealing 
> with different charsets in vcards.
> It solves e.g. https://bugs.kde.org/show_bug.cgi?id=98790
> This is mainly a backport from KDE4 where it's already solved.
Well, in KDE4 the input for the vCard parser is a QByteArray, in other
words plain data without previous convertion. In KDE3 the vCard parser
expects a QString, so you always need at least one convertion from the
raw data (QCString) to QString. From your patch it looks like to always
use latin1. Are you sure that doesn't remove any information from the
input data?

The right fix would be to use QCString as input data for vCard parser,
however that's not possible because it's SIC/BIC. (I know, bad design
in 3.x cycle...)

So if you are _really, really_ sure that your patch doesn't break _any_
other usage of the parser in KDE3, I'm fine with a commit, otherwise I
don't see a chance to fix it.

Ciao,
Tobias
-- 
Separate politics from religion and economy!
The Council of the European Union is an undemocratic and illegal institution!

["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]