[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [patch] make gpgme++ portable to msvc
From:       Jaroslaw Staniek <js () iidea ! pl>
Date:       2007-12-11 12:47:28
Message-ID: 475E86E0.70003 () iidea ! pl
[Download RAW message or body]

Marc Mutz said the following, On 2007-12-08 11:20:

> <snip>
>> Index: result_p.h
>> ===================================================================
>> --- result_p.h  (revision 746016)
>> +++ result_p.h  (working copy)
>> @@ -33,7 +33,7 @@
>>  
>>  #define make_error_ctor(x) \
>>  GpgME::x::x( const Error & error ) \
>> -  : GpgME::Result( error ), d( 0 ) \
>> +  : GpgME::Result( error.toErrorCode() ), d( 0 ) \
> 
> GpgME::Result should probably take an GpgME::Error as ctor arg right away, 
> here, don't you think? :)

So remove Error(int) and add
explicit Result( const Error& error = Error() ) : mError( error ) {} ?

And add changes like this averywhere?:

GpgME::VerificationResult::VerificationResult( gpgme_ctx_t ctx, int error )
   : GpgME::Result( Error(error) ), d( 0 )
                    ^^^^^^

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]