[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Request to exclude KMail from the KDE 4.0 release
From:       Kevin Krammer <kevin.krammer () gmx ! at>
Date:       2007-12-10 0:27:41
Message-ID: 200712100127.55989.kevin.krammer () gmx ! at
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Sunday 09 December 2007, Thomas McGuire wrote:

> branch. I also wouldn't work on the encryption stuff, as the KDAB people
> already work on that (it seems).

Signing, Encryping and Decrypting using OpenPGP works, check of signatures 
doesn't.

> For the editor stuff, these things need to be done properly, maybe even
> moving some functions from KMCompseWin to KMeditor. Now is the only chance
> to get the design right.
>
> As for side-effects (the code in KMail is a bit complicated in places),
> reviewing the patches will certainly help.

The first part of the patch connects the AFAIK correct slot for explicit spell 
checking. This was a QObject::connect warning before.

Checking seems to work, but I couldn't find where the text for the statusbar 
comes from because it isn't reset properly after finishing the check :(

Second part would in theory toggle automatic spellchecking, however it stays 
disabled since acceptRichText() is true and in this case KTextEditor does not 
call createHighlighter().

In any case KMeditor::createHighlighter() instaniates its own email 
highlighter, which has a Sonnet include but does not seem to use it.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

["composer-spellcheck.diff" (text/x-diff)]

Index: kmcomposewin.cpp
===================================================================
--- kmcomposewin.cpp	(Revision 746721)
+++ kmcomposewin.cpp	(Arbeitskopie)
@@ -1087,7 +1087,7 @@
   KStandardAction::findNext( mEditor, SLOT(slotFindNext()), actionCollection() );
 
   KStandardAction::replace( mEditor, SLOT(slotReplace()), actionCollection() );
-  actionCollection()->addAction( KStandardAction::Spelling , "spellcheck", this, \
SLOT(checkSpelling()) ); +  actionCollection()->addAction( KStandardAction::Spelling \
, "spellcheck", mEditor, SLOT(checkSpelling()) );  
   mPasteQuotation = new KAction( i18n("Pa&ste as Quotation"), this );
   actionCollection()->addAction("paste_quoted", mPasteQuotation );
@@ -3882,12 +3882,8 @@
 //-----------------------------------------------------------------------------
 void KMComposeWin::slotAutoSpellCheckingToggled( bool on )
 {
-//Laurent Fix me
-/*
-  if ( mEditor->autoSpellChecking( on ) == -1 ) {
-    mAutoSpellCheckingAction->setChecked( false ); // set it to false again
-  }
-*/
+  mEditor->setCheckSpellingEnabled( on );
+
   QString temp;
   if ( on ) {
     temp = i18n( "Spellcheck: on" );


["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]