[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] kabc/distributionlist: Entry class returns references
From:       Kevin Krammer <kevin.krammer () gmx ! at>
Date:       2007-08-30 9:57:37
Message-ID: 200708301157.37892.kevin.krammer () gmx ! at
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 30 August 2007, Kevin Krammer wrote:
> On Thursday 30 August 2007, Tobias Koenig wrote:
> > On Thu, Aug 30, 2007 at 10:33:34AM +0200, Kevin Krammer wrote:
> > > Hi Tobias,
> >
> > Hi Kevin,
> >
> > > the inner class Enrtry of DistributionList returns email and addressee
> > > as references. Do you think it is still possible to change that to
> > > "return copy"?
> >
> > Yes, but then you have to add a setEmail() and setAddressee() function
> > as well and search for all occurences in the kde code to change it!
>
> Hmm, the methods are "const"
> I'll leave them for now and just commit the API dox.
>
> Will try to hunt all uses of the methods down later and then send a patch
> for review.

Oh, boy!
The DistributionList and its entry is basically duplicated in kdepim/libkdepim

The one in kdepimlibs/kabc is copyrighted by Cornelius, the one in 
kdepim/libkdepim by David.

Is there a specific reason for this or did this happen as part of a 
merge/move?

Cheers.
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]