From kde-pim  Thu Aug 23 12:13:41 2007
From: Kevin Krammer <kevin.krammer () gmx ! at>
Date: Thu, 23 Aug 2007 12:13:41 +0000
To: kde-pim
Subject: Re: [Kde-pim] [patch] Akonadi Control .desktop lookup based on XDG
Message-Id: <200708231414.09124.kevin.krammer () gmx ! at>
X-MARC-Message: https://marc.info/?l=kde-pim&m=118787131910297
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1329844273=="

--===============1329844273==
Content-Type: multipart/signed;
  boundary="nextPart5404548.r8Jbk1f4ai";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart5404548.r8Jbk1f4ai
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Thursday 23 August 2007, Volker Krause wrote:
> On Wednesday 22 August 2007 00:30:46 Kevin Krammer wrote:
> > Since Volker seems to like my patches I have another one to review ;)
> > Also touching a class with Tobias' copyright in it, so maybe he wants to
> > have a look as well. (server/control/agentmanager)
>
> And I like this one as well :)

Excellent :)
Comitted

> So far noone really cared about this stuff since it doesn't matter for
> developing, but it's extremely important for actual deployments.

Yes, I wanted to have this incorporated before any actual deployment, since=
 at=20
this point we do not have to care about compatability yet.

Btw, a question on testing. Until know my changes were basically just touch=
ing=20
connection handling/setup and testing was pretty much just looking if Akona=
di=20
control could start all service processes correctly when I launch=20
akonadiconsole.

However I am unsure how to test actual data transfer things. When I add a=20
vcard resource (on a copy of my std.vcf) in akonadiconsole, I see it listed=
,=20
there are config files generated in .config/akonadi but I am not sure where=
 I=20
should be able to see or retrieve the contact data.

> > I have seen it referenced from CMakeLists.txt files in searchprovider,
> > resources and agents and I would have provided a patch for those as wel=
l,
> > but there is also a "share/apps" based path in
> > libakonadi/itemserializer.cpp and I am not sure if there are any cross
> > dependencies.
>
> This is needed by the plugin loader (libkdepim/pluginloader.h), which
> internally uses KStandardDirs. But this is just used on the client side
> (which has KDE dependencies anyway), so I don't think that's a problem.

Right, don't see a problem with this either.
I'll see what I can do with the searchprovider and agent .desktop files sin=
ce=20
from the point of view of akonadi control it doesn't care how they are=20
implemented.

> Also, I would like to get rid of the duplicated xdgbasedirs.* files. I see
> two ways of doing this: putting it into libakonadiprotocol which contains
> shared qt-only code between client and server (and is currently well hidd=
en
> in the libakonadi folder ;-) ) or simply adding the same source file to
> libakonadi and the server (which should work since we don't need to export
> the XdgBaseDir class).

Yes, this duplication is really bad. Any change has to be applied twice :(
Maybe another variant might be a "SVN symlink" (or whatever they are called=
,=20
like the admin/ directory in 3.5 branch)

Cheers,
Kevin

=2D-=20
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

--nextPart5404548.r8Jbk1f4ai
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBGzXoQnKMhG6pzZJIRAmQdAJ44eq5hSN3ctZcJWMWMOClsRO1kSgCfWzpq
Yd3yHixyBD2WI83EZm/zATY=
=nhhg
-----END PGP SIGNATURE-----

--nextPart5404548.r8Jbk1f4ai--

--===============1329844273==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============1329844273==--