From kde-pim  Mon Aug 20 21:40:57 2007
From: Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date: Mon, 20 Aug 2007 21:40:57 +0000
To: kde-pim
Subject: Re: [Kde-pim] [PATCH] Change two methods in KPimIdentities
Message-Id: <200708202341.01099 () erwin ! ingo-kloecker ! de>
X-MARC-Message: https://marc.info/?l=kde-pim&m=118764676321089
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0849001307=="

--===============0849001307==
Content-type: multipart/signed; boundary=nextPart1490107.A7ISzClCJL;
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-transfer-encoding: 7bit

--nextPart1490107.A7ISzClCJL
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Monday 20 August 2007 01:41, Thomas McGuire wrote:
> Hello,
>
> I am asking for permission to change two methods of the Identity
> class of KPimIdentities. These methods are only used by KMail.
>
> The rather small patch is attached.
>
> The only thing that changes is that the transport for each identity
> is now stored as an int instead of a string.
>
> This makes sense because the mailtransport library, which was
> recently introduced, uses int IDs as identifiers for the transports.
> Although KMail could use names to identify transports, this would
> make the code more cumbersome in some places. Using IDs is more
> natural.
>
> For reference, I also attached the KMail patch to deal with the
> changes. Note that the patch also gets rid of some cruft which is now
> handled inside mailtransport and fixes a bug or two (and does
> hopefully not introduce more).

I'm okay with the change, but there are two things we/you will have to=20
keep in mind:
a) You will have to provide an upgrade script taking care of adapting=20
old configuration files to the changes.
b) After this change the X-KMail-Transport header created by older=20
versions of KMail will no longer work. This might in particular effect=20
templates. I'm not sure what to do about this. One way around this=20
problem would be some legacy support code mapping the old transport=20
names to the new ids. This code would be removed again in KDE 4.1. At=20
most, I propose to use the new header X-KMail-TransportId instead of=20
re-using the existing X-KMail-Transport header.

I didn't spot any obvious errors in the patch. So feel free to commit=20
(but keep the above two points in mind).


Regards,
Ingo

--nextPart1490107.A7ISzClCJL
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBGygptGnR+RTDgudgRAk0BAKCPkcUAoITb/DV9euGb4QD/kaGeGgCgsAnC
cBcHHV8P5hzrnely0mlovf4=
=jSZn
-----END PGP SIGNATURE-----

--nextPart1490107.A7ISzClCJL--

--===============0849001307==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============0849001307==--