[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Change two methods in KPimIdentities
From:       Thomas McGuire <thomas.mcguire () gmx ! net>
Date:       2007-08-20 10:08:15
Message-ID: 200708201208.15708.thomas.mcguire () gmx ! net
[Download RAW message or body]

Hi,

On Monday 20 August 2007, Tom Albers wrote:
> At Monday 20 August 2007 01:41, you wrote:
> > I am asking for permission to change two methods of the Identity class of
> > KPimIdentities. These methods are only used by KMail.
> >
> > The rather small patch is attached.
> >
> > The only thing that changes is that the transport for each identity is
> > now stored as an int instead of a string.
> >
> > This makes sense because the mailtransport library, which was recently
> > introduced, uses int IDs as identifiers for the transports.
> > Although KMail could use names to identify transports, this would make
> > the code more cumbersome in some places. Using IDs is more natural.
> >
> > For reference, I also attached the KMail patch to deal with the changes.
> > Note that the patch also gets rid of some cruft which is now handled
> > inside mailtransport and fixes a bug or two (and does hopefully not
> > introduce more).
> >
> > OK to commit next monday?
> > (if there are no objections, I'll commit)
>
> I don't have any problem with the patch, except I did not look at the
> id-generation in general. If it can contain letters or starting zero's,
> this won't work.
The transport IDs are returned as integers from the mailtransport library, and 
therefore can not contain leading zeros or other stuff.

> Other than that, please commit (today is fine for me) ( i did not look at
> the kmail diff).
Ok, I'll commit this evening if there are no further comments.

Cheers,
Thomas


_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]