From kde-pim Sat Aug 11 10:32:28 2007 From: "Oleg Sidorkin" Date: Sat, 11 Aug 2007 10:32:28 +0000 To: kde-pim Subject: [Kde-pim] [PATCH] Addressbook conduit crashing kpilot on second Message-Id: X-MARC-Message: https://marc.info/?l=kde-pim&m=118682838100380 MIME-Version: 1 Content-Type: multipart/mixed; boundary="------=_Part_13983_14721100.1186828348545" ------=_Part_13983_14721100.1186828348545 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi! There is a problem in KPilot's abbrowser conduit, that leads to crash of kpilotDaemon during second synchronization (kdepim-users thread is here: http://lists.kde.org/?t=118125302600001&r=1&w=2). I faced the same problem after updating KDE from 3.5.6 to 3.5.7. Abbrowser-conduid uses singleton (StdAddressbook) when it is configured to use standart addressbook, and deletes it in destructor soit tries to access already deleted class during second run and crashes. The attached patch seems to fix the problem in Kpilot 4.9.1. -- Oleg S. Sidorkin ------=_Part_13983_14721100.1186828348545 Content-Type: text/plain; name=kpilot-abbrowser.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f57yktp6 Content-Disposition: attachment; filename="kpilot-abbrowser.patch" ZGlmZiAtdSAtciAtcCBrZGVwaW0tMy41Ljcva3BpbG90L2NvbmR1aXRzL2FiYnJvd3NlcmNvbmR1 aXQvYWJicm93c2VyLWNvbmR1aXQuY2Mga2RlcGltLTMuNS43LXBhdGNoZWQva3BpbG90L2NvbmR1 aXRzL2FiYnJvd3NlcmNvbmR1aXQvYWJicm93c2VyLWNvbmR1aXQuY2MKLS0tIGtkZXBpbS0zLjUu Ny9rcGlsb3QvY29uZHVpdHMvYWJicm93c2VyY29uZHVpdC9hYmJyb3dzZXItY29uZHVpdC5jYwky MDA3LTA1LTE0IDExOjU0OjUyLjAwMDAwMDAwMCArMDQwMAorKysga2RlcGltLTMuNS43LXBhdGNo ZWQva3BpbG90L2NvbmR1aXRzL2FiYnJvd3NlcmNvbmR1aXQvYWJicm93c2VyLWNvbmR1aXQuY2MJ MjAwNy0wOC0wOCAwMzowNjoyNC4wMDAwMDAwMDAgKzA0MDAKQEAgLTEwNiw3ICsxMDYsNyBAQCBp bmxpbmUgaW50IGZheFR5cGVPblBDKCkKIHVzaW5nIG5hbWVzcGFjZSBLQUJDOwogCiBBZGRyZXNz Qm9vayAqQWJicm93c2VyQ29uZHVpdDo6YUJvb2s9MEw7Ci0KK2Jvb2wgc2hvdWxkRGVsZXRlPWZh bHNlOwogCiAvKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqCiAgICAgICAgICAgICAgICAgICAgICAgICBDIE8gTiBTIFQg UiBVIEMgVCBPIFIKQEAgLTE0Miw5ICsxNDIsNyBAQCBBYmJyb3dzZXJDb25kdWl0Ojp+QWJicm93 c2VyQ29uZHVpdCgpCiAJCWZUaWNrZXQ9MEw7CiAJfQogCi0JREVCVUdLUElMT1QgPDwgZm5hbWUg PDwgIjogRGVsZXRpbmcgYWRkcmVzc2Jvb2siIDw8IGVuZGw7Ci0JS1BJTE9UX0RFTEVURShhQm9v ayk7Ci0KKwlfY2xlYW51cEFkZHJlZXNzQm9va1BvaW50ZXIoKTsKIAkvLyB1bnVzZWQgZnVuY3Rp b24gd2FybmluZ3MuCiAJY29tcGlsZV90aW1lX2NoZWNrKCk7CiB9CkBAIC0yODUsNiArMjgzLDcg QEAgYm9vbCBBYmJyb3dzZXJDb25kdWl0OjpfbG9hZEFkZHJlc3NCb29rKAogCQljYXNlIEFiYnJv d3NlclNldHRpbmdzOjplQWJvb2tSZXNvdXJjZToKIAkJCURFQlVHS1BJTE9UPDwiTG9hZGluZyBz dGFuZGFyZCBhZGRyZXNzYm9vayI8PGVuZGw7CiAJCQlhQm9vayA9IFN0ZEFkZHJlc3NCb29rOjpz ZWxmKCB0cnVlICk7CisJCQlzaG91bGREZWxldGU9ZmFsc2U7CiAJCQlicmVhazsKIAkJY2FzZSBB YmJyb3dzZXJTZXR0aW5nczo6ZUFib29rRmlsZToKIAkJeyAvLyBpbml0aWFsaXplIHRoZSBhYm9v ayB3aXRoIHRoZSBnaXZlbiBmaWxlCkBAIC0zMTgsNiArMzE3LDcgQEAgYm9vbCBBYmJyb3dzZXJD b25kdWl0OjpfbG9hZEFkZHJlc3NCb29rKAogCQkJCXN0b3BUaWNrbGUoKTsKIAkJCQlyZXR1cm4g ZmFsc2U7CiAJCQl9CisJCQlzaG91bGREZWxldGU9dHJ1ZTsKIAkJCWJyZWFrOwogCQl9CiAJCWRl ZmF1bHQ6IGJyZWFrOwpAQCAtMzMxLDcgKzMzMSw3IEBAIGJvb2wgQWJicm93c2VyQ29uZHVpdDo6 X2xvYWRBZGRyZXNzQm9vaygKIAkJZW1pdCBsb2dFcnJvcihpMThuKCJVbmFibGUgdG8gaW5pdGlh bGl6ZSBhbmQgbG9hZCB0aGUgYWRkcmVzc2Jvb2sgZm9yIHRoZSBzeW5jLiIpICk7CiAJCWFkZFN5 bmNMb2dFbnRyeShpMThuKCJVbmFibGUgdG8gaW5pdGlhbGl6ZSBhbmQgbG9hZCB0aGUgYWRkcmVz c2Jvb2sgZm9yIHRoZSBzeW5jLiIpICk7CiAJCVdBUk5JTkdLUElMT1QgPDwgIlVuYWJsZSB0byBp bml0aWFsaXplIHRoZSBhZGRyZXNzYm9vayBmb3IgdGhlIHN5bmMuIiA8PCBlbmRsOwotCQlLUElM T1RfREVMRVRFKGFCb29rKTsKKwkJX2NsZWFudXBBZGRyZWVzc0Jvb2tQb2ludGVyKCk7CiAJCXN0 b3BUaWNrbGUoKTsKIAkJcmV0dXJuIGZhbHNlOwogCX0KQEAgLTM0Myw3ICszNDMsNyBAQCBib29s IEFiYnJvd3NlckNvbmR1aXQ6Ol9sb2FkQWRkcmVzc0Jvb2soCiAJCVdBUk5JTkdLUElMT1QgPDwg IlVuYWJsZSB0byBsb2NrIGFkZHJlc3Nib29rIGZvciB3cml0aW5nICIgPDwgZW5kbDsKIAkJZW1p dCBsb2dFcnJvcihpMThuKCJVbmFibGUgdG8gbG9jayBhZGRyZXNzYm9vayBmb3Igd3JpdGluZy4g IENhbid0IHN5bmMhIikpOwogCQlhZGRTeW5jTG9nRW50cnkoaTE4bigiVW5hYmxlIHRvIGxvY2sg YWRkcmVzc2Jvb2sgZm9yIHdyaXRpbmcuICBDYW4ndCBzeW5jISIpKTsKLQkJS1BJTE9UX0RFTEVU RShhQm9vayk7CisJCV9jbGVhbnVwQWRkcmVlc3NCb29rUG9pbnRlcigpOwogCQlzdG9wVGlja2xl KCk7CiAJCXJldHVybiBmYWxzZTsKIAl9CkBAIC00NDIsNyArNDQyLDE4IEBAIHZvaWQgQWJicm93 c2VyQ29uZHVpdDo6X3NldEFwcEluZm8oKQogfQogCiAKLQordm9pZCBBYmJyb3dzZXJDb25kdWl0 OjpfY2xlYW51cEFkZHJlZXNzQm9va1BvaW50ZXIoKQoreworICAgICAgICBpZiAoc2hvdWxkRGVs ZXRlKQorICAgICAgICB7CisgICAgICAgICAgICAgICAgS1BJTE9UX0RFTEVURShhQm9vayk7Cisg ICAgICAgICAgICAgICAgc2hvdWxkRGVsZXRlPWZhbHNlOworICAgICAgICB9CisgICAgICAgIGVs c2UKKyAgICAgICAgeworICAgICAgICAgICAgICAgIGFCb29rPTBMOworCX0JCQkJCQkJCQkJCQkg ICAgICAgICAKK30KIAogCiAKZGlmZiAtdSAtciAtcCBrZGVwaW0tMy41Ljcva3BpbG90L2NvbmR1 aXRzL2FiYnJvd3NlcmNvbmR1aXQvYWJicm93c2VyLWNvbmR1aXQuaCBrZGVwaW0tMy41LjctcGF0 Y2hlZC9rcGlsb3QvY29uZHVpdHMvYWJicm93c2VyY29uZHVpdC9hYmJyb3dzZXItY29uZHVpdC5o Ci0tLSBrZGVwaW0tMy41Ljcva3BpbG90L2NvbmR1aXRzL2FiYnJvd3NlcmNvbmR1aXQvYWJicm93 c2VyLWNvbmR1aXQuaAkyMDA3LTA1LTE0IDExOjU0OjUyLjAwMDAwMDAwMCArMDQwMAorKysga2Rl cGltLTMuNS43LXBhdGNoZWQva3BpbG90L2NvbmR1aXRzL2FiYnJvd3NlcmNvbmR1aXQvYWJicm93 c2VyLWNvbmR1aXQuaAkyMDA3LTA4LTA4IDAzOjAxOjI4LjAwMDAwMDAwMCArMDQwMApAQCAtMTEw LDcgKzExMCw3IEBAIHByaXZhdGU6CiAJdm9pZCBfZ2V0QXBwSW5mbygpOwogCXZvaWQgX3NldEFw cEluZm8oKTsKIAotCisJdm9pZCBfY2xlYW51cEFkZHJlZXNzQm9va1BvaW50ZXIoKTsKIAogCiAK ------=_Part_13983_14721100.1186828348545 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KDE PIM mailing list kde-pim@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ ------=_Part_13983_14721100.1186828348545--