From kde-pim  Wed Aug 01 14:10:11 2007
From: Volker Krause <vkrause () kde ! org>
Date: Wed, 01 Aug 2007 14:10:11 +0000
To: kde-pim
Subject: Re: [Kde-pim] Question on Akonadi data connection
Message-Id: <200708011610.14123.vkrause () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-pim&m=118597767116057
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0414631125=="

--===============0414631125==
Content-Type: multipart/signed;
  boundary="nextPart169431006.9IJZruL2ui";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart169431006.9IJZruL2ui
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Monday 30 July 2007 10:07:16 Tobias Koenig wrote:
> On Mon, Jul 30, 2007 at 02:48:16AM +0200, Kevin Krammer wrote:
> > Attached is a first, hackish, implementation.
>
> Looks good so far :)
>
> > I have a couple of ideas for improvements:
> >
> > 1) class Akonadi should not have different inheritance but just derive
> > from QObject and connect to a member's newConnection signal (both
> > QTcpServer and KLocalSocketServer have this).
>
> Why not inheriting from it? Because of the compile time switch?
> At the time when KLocalSocket will do the abstraction for windows as
> well I don't see a problem from inheriting KlocalSocket.
>
> > 2) The socket address should rather be an abtract unix socket, e.g. like
> > D-Bus Currently, if the akonadiserver crashed, it leaves the socket
> > around and cannot listen on it anymore
>
> We just have to unlink the unix socket file on a restart of akonadi.
> That's a know issue with unix domain sockets.
>
> > 3) depending on (1) it might be an option to make the connection type
> > configurable, i.e. getting rid of most of the #ifdef, just using them f=
or
> > defaults if the config does not exist yet.
>
> Well, we need the on-instance-per-user approach, so KLocalSocket is the
> way to go. That Windows doesn't support unix sockets is the real
> problem, hopefully Thiago finds a solution for this.
>
> If there is no further objection from Volker or Till, please commit.

Sorry for the late reply. Kevin, please feel free to commit your patches, t=
hey=20
all look fine to me.

Thanks
Volker

--nextPart169431006.9IJZruL2ui
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBGsJRGf5bM1k0S0kcRAuQwAJ9GGJyPjgaceT4lOrHETyZOb6bxHgCeIxM0
WlFgOo7yjR98dGB7MSquK/g=
=tQNe
-----END PGP SIGNATURE-----

--nextPart169431006.9IJZruL2ui--


--===============0414631125==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============0414631125==--