[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] About KOrganizer's timezone setting
From:       "David Jarvie" <lists () astrojar ! org ! uk>
Date:       2007-07-30 16:55:11
Message-ID: 36821.S0VKQUNDQxA=.1185814511.squirrel () www ! sensical ! net
[Download RAW message or body]

On Monday 30 July 2007 16:56, Bruno Virlet wrote:
> On Monday 30 July 2007 17:11:35 David Jarvie wrote:
>> Your patch looks fine except that the API comments don't tally with the
>> implementation code. The "spec" parameter has the following description:
>>
>> "If set, return the date in the given spec, else use the system spec"
>>
>> In fact the patch code doesn't use the system spec, but instead uses
>> whatever spec the incidence uses (which could of course be different for
>> different incidences). If by system spec you mean the computer's system
>> time zone, you need to use KSystemTimeZones::local().
> Attached is the correct patch (will also takes todo.cpp/h in account)

That looks fine. :)

-- 
David Jarvie.
KAlarm author & maintainer.
http://www.astrojar.org.uk/kalarm

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]