[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] KBlog library
From:       Christian Weilbach <christian () whiletaker ! homeip ! net>
Date:       2006-09-13 13:32:42
Message-ID: 200609131530.27128.christian () whiletaker ! homeip ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


> On Tuesday 12 September 2006 20:54, Christian Weilbach wrote:
> >Hi,
> >
> >I'm sending you a first code for the kblog library in kdepimlibs. I don't
> > want to submit it right now, since the documentation is not finished yet
> > and I haven't tested the functionality of the ported code yet. But I
> > would like to know if there are any problems with it.
>
> Christian,
>  
> I can see that you have done a lot of work to make this new library follow
> our rules for kdepimlibs.  Thank you.
>
> As long as the new code compiles I'm ok with committing it into kdepimlibs.
> Do you have an SVN account yet?
Yes. Am I able to commit or do I need special rights?
>
> Some comments:
>  - change the "This file is part of kdepimlibs" comments to "This file is
> part of the kblog library" - there are coding style and indentation issues
> that we can address later. see
done
> http://korganizer.kde.org/develop/hacking.html
>  - put the KBLOG_EXPORT macro onto the public class definitions
o.k.
>  - yes, you need a lot more doxygen comments.  you also need a
> Mainpage.dox. - you already implemented d-pointers.  excellent.
o.k.
>  - what is kndDebug()?
I used kdDebug() before, but only since I'm not a pro in debugging and thought 
it would be the best to make it really noisy to find bugs in the lib. I can 
change that, if there are better ways...
>  - you need tests.  a least unit tests for your public classes
I know. I will do this once the library is more complete and working.
>  - David will hurt you .. you are using QDateTimes.  Better change over to
> KDateTimes. But we can probably address that later too.  We all have a lot
> of work changing over to KDateTime.
o.k. I'm not making heavy use of them so maybe I can simply replace them?
>
> Well done, Welcome to KDEPIM project,
Yeah cool.
> Allen
Christian
>
> PS. do you have plans to use this library in a client?  KOrganizer perhaps?
This was and still is the motivation and this is where the code originally 
comes from, but I hope to give a good library for plasma widgets, too, and 
I'm not sure how to do this best. We could add a dbus interface to the 
KOrganizer blog adaptor or add some bindings for ecma script ( I'm an 
absolute n00b here ).

-- 
My blog: http://whiletaker.homeip.net

No brain - no headache!

You need a professional website?
www.helena-artworks.de - press IT!

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]