--Boundary-00=_8dx7EXrF5W2q9yW
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Hi,
I want to add the attached accessibility fix to the 3.5.5 branch.
It makes the colors in the article list configurable - which are currently
hardcoded to blue and red. That is a no-no accessiblity-wise and constrains
the use of Akregator for color-blind people [1]. To me, that's reason enough
to add the configuration options for 3.5.5.
The patch is in trunk. It isn't extensively tested yet, but the changes aren't
complex either.
Four new i18n'd strings are added ("Article List Colors", "Use custom
colors", "Unread articles", "New articles").
Frank
[1] http://bugs.kde.org/show_bug.cgi?id=116079
--Boundary-00=_8dx7EXrF5W2q9yW
Content-Type: text/x-diff;
charset="us-ascii";
name="akregator-configurable-colors.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="akregator-configurable-colors.diff"
Index: akregator.kcfg
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- akregator.kcfg (revision 573936)
+++ akregator.kcfg (working copy)
@@ -40,6 +40,16 @@
+
+ false
+
+
+ #0000FF
+
+
+ #FF0000
+
+ =20
Index: articlelistview.cpp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- articlelistview.cpp (revision 573936)
+++ articlelistview.cpp (working copy)
@@ -181,15 +181,20 @@
QColorGroup cg2(cg);
=20
if (article().status() =3D=3D Article::Unread)
=2D cg2.setColor(QColorGroup::Text, Qt::blue);
+ cg2.setColor(QColorGroup::Text, Settings::useCustomColors() ? =
Settings::colorUnreadArticles() : Qt::blue);
else // New
=2D cg2.setColor(QColorGroup::Text, Qt::red);
+ cg2.setColor(QColorGroup::Text, Settings::useCustomColors() ? =
Settings::colorNewArticles() : Qt::red);
=20
KListViewItem::paintCell( p, cg2, column, width, align );
}
=20
}
=20
+void ArticleListView::slotPaletteOrFontChanged()
+{
+ triggerUpdate();
+}
+
void ArticleListView::ArticleItem::updateItem(const Article& article)
{
m_article =3D article;
Index: articlelistview.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- articlelistview.h (revision 573936)
+++ articlelistview.h (working copy)
@@ -80,6 +80,8 @@
/** selects next unread article in list view, first unread art=
icle if no article was selected */
void slotNextUnreadArticle();
=20
+ void slotPaletteOrFontChanged();
+ =20
signals:
void signalArticleChosen(const Article& article);
void signalDoubleClicked(const Article&, const QPoint&, int);
Index: settings_appearance.ui
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- settings_appearance.ui (revision 573936)
+++ settings_appearance.ui (working copy)
@@ -10,20 +10,20 @@
0
0
418
=2D 377
+ 566
General
=2D
+
unnamed
0
=2D
+
groupBox3
@@ -114,8 +114,25 @@
=2D
+
+ spacer1
+
+
+ Vertical
+
+
+ Expanding
+
+
+
+ 20
+ 41
+
+
+
+
+
FontsGroupBox
@@ -179,7 +196,7 @@
=2D
+
kcfg_UnderlineLinks
@@ -187,24 +204,99 @@
&Underline links
=2D
+
=2D spacer1
+ groupBox3_2
=2D
=2D Vertical
+
+ Article List Colors
=2D
=2D Expanding
=2D
=2D
=2D
=2D 20
=2D 41
=2D
=2D
=2D
=2D
+
+
+ unnamed
+
+
+
+ kcfg_UseCustomColors
+
+
+ Use custom colors
+
+
+
+
+ layout1
+
+
+
+ unnamed
+
+
+
+ lbl_unreadArticles
+
+
+ false
+
+
+ Unread articles
+
+
+
+
+ kcfg_ColorNewArticles
+
+
+ false
+
+
+
+
+
+
+
+ kcfg_ColorUnreadArticles
+
+
+ false
+
+
+
+
+
+
+
+ lbl_newArticles
+
+
+ false
+
+
+ New articles
+
+
+
+
+
+
+ spacer2
+
+
+ Horizontal
+
+
+ Expanding
+
+
+
+ 110
+ 20
+
+
+
+
+
+
@@ -233,18 +325,38 @@
kcfg_MinimumFontSize
setValue(int)
+
+ kcfg_UseCustomColors
+ toggled(bool)
+ kcfg_ColorUnreadArticles
+ setEnabled(bool)
+
+
+ kcfg_UseCustomColors
+ toggled(bool)
+ kcfg_ColorNewArticles
+ setEnabled(bool)
+
+
+ kcfg_UseCustomColors
+ toggled(bool)
+ lbl_unreadArticles
+ setEnabled(bool)
+
+
+ kcfg_UseCustomColors
+ toggled(bool)
+ lbl_newArticles
+ setEnabled(bool)
+
=2D knuminput.h
=2D knuminput.h
kfontcombo.h
=2D klineedit.h
kfontcombo.h
=2D klineedit.h
kfontcombo.h
=2D klineedit.h
kfontcombo.h
=2D klineedit.h
+ kcolorbutton.h
+ kcolorbutton.h
Index: akregator_view.cpp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- akregator_view.cpp (revision 577072)
+++ akregator_view.cpp (working copy)
@@ -297,6 +297,8 @@
connect( m_articleList, SIGNAL(signalDoubleClicked(const Article&, con=
st QPoint&, int)),
this, SLOT( slotOpenArticleExternal(const Article&, const =
QPoint&, int)) );
=20
+ connect( m_part, SIGNAL(signalSettingsChanged()), m_articleList, SLOT(=
slotPaletteOrFontChanged()));
+ =20
m_articleViewer =3D new ArticleViewer(m_articleSplitter, "article_view=
er");
m_articleViewer->setSafeMode(); // disable JS, Java, etc...
=20
--Boundary-00=_8dx7EXrF5W2q9yW
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
--Boundary-00=_8dx7EXrF5W2q9yW--