From kde-pim  Fri Aug 25 15:30:01 2006
From: Frank Osterfeld <frank.osterfeld () gmx ! de>
Date: Fri, 25 Aug 2006 15:30:01 +0000
To: kde-pim
Subject: [Kde-pim] Akregator accessibility fix for 3.5.5 with additional
Message-Id: <200608251730.04555.frank.osterfeld () gmx ! de>
X-MARC-Message: https://marc.info/?l=kde-pim&m=115651956021805
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-00=_8dx7EXrF5W2q9yW"

--Boundary-00=_8dx7EXrF5W2q9yW
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

I want to add the attached accessibility fix to the 3.5.5 branch.
It makes the colors in the article list configurable - which are currently 
hardcoded to blue and red. That is a no-no accessiblity-wise and constrains 
the use of Akregator for color-blind people [1]. To me, that's reason enough 
to add the configuration options for 3.5.5. 

The patch is in trunk. It isn't extensively tested yet, but the changes aren't 
complex either. 

Four new i18n'd strings are added ("Article List Colors", "Use custom 
colors", "Unread articles", "New articles").

Frank

[1] http://bugs.kde.org/show_bug.cgi?id=116079

--Boundary-00=_8dx7EXrF5W2q9yW
Content-Type: text/x-diff;
  charset="us-ascii";
  name="akregator-configurable-colors.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="akregator-configurable-colors.diff"

Index: akregator.kcfg
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- akregator.kcfg	(revision 573936)
+++ akregator.kcfg	(working copy)
@@ -40,6 +40,16 @@
    <entry key=3D"Fixed Font" type=3D"String" />
    <entry key=3D"Serif Font" type=3D"String" />
    <entry key=3D"Sans Serif Font" type=3D"String" />
+   <entry key=3D"UseCustomColors" type=3D"Bool">
+        <default>false</default>
+   </entry>
+    <entry key=3D"ColorUnreadArticles" type=3D"Color">
+        <default>#0000FF</default>
+    </entry>
+    <entry key=3D"ColorNewArticles" type=3D"Color">
+        <default>#FF0000</default>
+    </entry>
+       =20
  </group>
  <group name=3D"HTML Settings" >
   <entry key=3D"Fonts" type=3D"StringList" />
Index: articlelistview.cpp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- articlelistview.cpp	(revision 573936)
+++ articlelistview.cpp	(working copy)
@@ -181,15 +181,20 @@
         QColorGroup cg2(cg);
    =20
         if (article().status() =3D=3D Article::Unread)
=2D            cg2.setColor(QColorGroup::Text, Qt::blue);
+            cg2.setColor(QColorGroup::Text, Settings::useCustomColors() ? =
Settings::colorUnreadArticles() : Qt::blue);
         else // New
=2D            cg2.setColor(QColorGroup::Text, Qt::red);
+            cg2.setColor(QColorGroup::Text, Settings::useCustomColors() ? =
Settings::colorNewArticles() : Qt::red);
    =20
         KListViewItem::paintCell( p, cg2, column, width, align );
     }
=20
 }
=20
+void ArticleListView::slotPaletteOrFontChanged()
+{
+    triggerUpdate();
+}
+
 void ArticleListView::ArticleItem::updateItem(const Article& article)
 {
     m_article =3D article;
Index: articlelistview.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- articlelistview.h	(revision 573936)
+++ articlelistview.h	(working copy)
@@ -80,6 +80,8 @@
             /** selects next unread article in list view, first unread art=
icle if no article was selected */
             void slotNextUnreadArticle();
=20
+            void slotPaletteOrFontChanged();
+           =20
         signals:
             void signalArticleChosen(const Article& article);
             void signalDoubleClicked(const Article&, const QPoint&, int);
Index: settings_appearance.ui
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- settings_appearance.ui	(revision 573936)
+++ settings_appearance.ui	(working copy)
@@ -10,20 +10,20 @@
             <x>0</x>
             <y>0</y>
             <width>418</width>
=2D            <height>377</height>
+            <height>566</height>
         </rect>
     </property>
     <property name=3D"caption">
         <string>General</string>
     </property>
=2D    <vbox>
+    <grid>
         <property name=3D"name">
             <cstring>unnamed</cstring>
         </property>
         <property name=3D"margin">
             <number>0</number>
         </property>
=2D        <widget class=3D"QGroupBox">
+        <widget class=3D"QGroupBox" row=3D"1" column=3D"0">
             <property name=3D"name">
                 <cstring>groupBox3</cstring>
             </property>
@@ -114,8 +114,25 @@
                 </widget>
             </grid>
         </widget>
=2D        <widget class=3D"QGroupBox">
+        <spacer row=3D"4" column=3D"0">
             <property name=3D"name">
+                <cstring>spacer1</cstring>
+            </property>
+            <property name=3D"orientation">
+                <enum>Vertical</enum>
+            </property>
+            <property name=3D"sizeType">
+                <enum>Expanding</enum>
+            </property>
+            <property name=3D"sizeHint">
+                <size>
+                    <width>20</width>
+                    <height>41</height>
+                </size>
+            </property>
+        </spacer>
+        <widget class=3D"QGroupBox" row=3D"2" column=3D"0">
+            <property name=3D"name">
                 <cstring>FontsGroupBox</cstring>
             </property>
             <property name=3D"title">
@@ -179,7 +196,7 @@
                 </widget>
             </grid>
         </widget>
=2D        <widget class=3D"QCheckBox">
+        <widget class=3D"QCheckBox" row=3D"3" column=3D"0">
             <property name=3D"name">
                 <cstring>kcfg_UnderlineLinks</cstring>
             </property>
@@ -187,24 +204,99 @@
                 <string>&amp;Underline links</string>
             </property>
         </widget>
=2D        <spacer>
+        <widget class=3D"QGroupBox" row=3D"0" column=3D"0">
             <property name=3D"name">
=2D                <cstring>spacer1</cstring>
+                <cstring>groupBox3_2</cstring>
             </property>
=2D            <property name=3D"orientation">
=2D                <enum>Vertical</enum>
+            <property name=3D"title">
+                <string>Article List Colors</string>
             </property>
=2D            <property name=3D"sizeType">
=2D                <enum>Expanding</enum>
=2D            </property>
=2D            <property name=3D"sizeHint">
=2D                <size>
=2D                    <width>20</width>
=2D                    <height>41</height>
=2D                </size>
=2D            </property>
=2D        </spacer>
=2D    </vbox>
+            <grid>
+                <property name=3D"name">
+                    <cstring>unnamed</cstring>
+                </property>
+                <widget class=3D"QCheckBox" row=3D"0" column=3D"0" rowspan=
=3D"1" colspan=3D"2">
+                    <property name=3D"name">
+                        <cstring>kcfg_UseCustomColors</cstring>
+                    </property>
+                    <property name=3D"text">
+                        <string>Use custom colors</string>
+                    </property>
+                </widget>
+                <widget class=3D"QLayoutWidget" row=3D"1" column=3D"0">
+                    <property name=3D"name">
+                        <cstring>layout1</cstring>
+                    </property>
+                    <grid>
+                        <property name=3D"name">
+                            <cstring>unnamed</cstring>
+                        </property>
+                        <widget class=3D"QLabel" row=3D"0" column=3D"0">
+                            <property name=3D"name">
+                                <cstring>lbl_unreadArticles</cstring>
+                            </property>
+                            <property name=3D"enabled">
+                                <bool>false</bool>
+                            </property>
+                            <property name=3D"text">
+                                <string>Unread articles</string>
+                            </property>
+                        </widget>
+                        <widget class=3D"KColorButton" row=3D"1" column=3D=
"1">
+                            <property name=3D"name">
+                                <cstring>kcfg_ColorNewArticles</cstring>
+                            </property>
+                            <property name=3D"enabled">
+                                <bool>false</bool>
+                            </property>
+                            <property name=3D"text">
+                                <string></string>
+                            </property>
+                        </widget>
+                        <widget class=3D"KColorButton" row=3D"0" column=3D=
"1">
+                            <property name=3D"name">
+                                <cstring>kcfg_ColorUnreadArticles</cstring>
+                            </property>
+                            <property name=3D"enabled">
+                                <bool>false</bool>
+                            </property>
+                            <property name=3D"text">
+                                <string></string>
+                            </property>
+                        </widget>
+                        <widget class=3D"QLabel" row=3D"1" column=3D"0">
+                            <property name=3D"name">
+                                <cstring>lbl_newArticles</cstring>
+                            </property>
+                            <property name=3D"enabled">
+                                <bool>false</bool>
+                            </property>
+                            <property name=3D"text">
+                                <string>New articles</string>
+                            </property>
+                        </widget>
+                    </grid>
+                </widget>
+                <spacer row=3D"1" column=3D"1">
+                    <property name=3D"name">
+                        <cstring>spacer2</cstring>
+                    </property>
+                    <property name=3D"orientation">
+                        <enum>Horizontal</enum>
+                    </property>
+                    <property name=3D"sizeType">
+                        <enum>Expanding</enum>
+                    </property>
+                    <property name=3D"sizeHint">
+                        <size>
+                            <width>110</width>
+                            <height>20</height>
+                        </size>
+                    </property>
+                </spacer>
+            </grid>
+        </widget>
+    </grid>
 </widget>
 <customwidgets>
 </customwidgets>
@@ -233,18 +325,38 @@
         <receiver>kcfg_MinimumFontSize</receiver>
         <slot>setValue(int)</slot>
     </connection>
+    <connection>
+        <sender>kcfg_UseCustomColors</sender>
+        <signal>toggled(bool)</signal>
+        <receiver>kcfg_ColorUnreadArticles</receiver>
+        <slot>setEnabled(bool)</slot>
+    </connection>
+    <connection>
+        <sender>kcfg_UseCustomColors</sender>
+        <signal>toggled(bool)</signal>
+        <receiver>kcfg_ColorNewArticles</receiver>
+        <slot>setEnabled(bool)</slot>
+    </connection>
+    <connection>
+        <sender>kcfg_UseCustomColors</sender>
+        <signal>toggled(bool)</signal>
+        <receiver>lbl_unreadArticles</receiver>
+        <slot>setEnabled(bool)</slot>
+    </connection>
+    <connection>
+        <sender>kcfg_UseCustomColors</sender>
+        <signal>toggled(bool)</signal>
+        <receiver>lbl_newArticles</receiver>
+        <slot>setEnabled(bool)</slot>
+    </connection>
 </connections>
 <layoutdefaults spacing=3D"6" margin=3D"11"/>
 <includehints>
=2D    <includehint>knuminput.h</includehint>
=2D    <includehint>knuminput.h</includehint>
     <includehint>kfontcombo.h</includehint>
=2D    <includehint>klineedit.h</includehint>
     <includehint>kfontcombo.h</includehint>
=2D    <includehint>klineedit.h</includehint>
     <includehint>kfontcombo.h</includehint>
=2D    <includehint>klineedit.h</includehint>
     <includehint>kfontcombo.h</includehint>
=2D    <includehint>klineedit.h</includehint>
+    <includehint>kcolorbutton.h</includehint>
+    <includehint>kcolorbutton.h</includehint>
 </includehints>
 </UI>
Index: akregator_view.cpp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- akregator_view.cpp	(revision 577072)
+++ akregator_view.cpp	(working copy)
@@ -297,6 +297,8 @@
     connect( m_articleList, SIGNAL(signalDoubleClicked(const Article&, con=
st QPoint&, int)),
                 this, SLOT( slotOpenArticleExternal(const Article&, const =
QPoint&, int)) );
=20
+    connect( m_part, SIGNAL(signalSettingsChanged()), m_articleList, SLOT(=
slotPaletteOrFontChanged()));
+   =20
     m_articleViewer =3D new ArticleViewer(m_articleSplitter, "article_view=
er");
     m_articleViewer->setSafeMode();  // disable JS, Java, etc...
=20

--Boundary-00=_8dx7EXrF5W2q9yW
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
--Boundary-00=_8dx7EXrF5W2q9yW--