[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] KLDAP Library
From:       Szombathelyi_György <gyurco () freemail ! hu>
Date:       2006-08-01 13:02:21
Message-ID: 44CF50DD.9050307 () freemail ! hu
[Download RAW message or body]

Hi!

Tobias Koenig írta:

> 
>  Generall issues:
>    - make all the inline functions to real functions, that might be a bit
>      slower in execution time but will help us to maintain the library
>      easier over the next years (and we'll have to do, for sure ;))

Ok, I'll do.
> 
>    - move all member variables to the private class already, hide as much
>      private information as possible!
It's in the class' private section, I really don't want to do it...I 
remember a discussion that concluded that's not mandatory to put 
everything into d pointer, but if there's enough pressure, I'll do it.
> 
>    - return the data by value not by const reference, QString & Co. are implicit
>      shared, so until you modify the returned value no copy will happens
>      and the code is more in shape with the rest of our APIs
I'll do.
> 
>  Specific issues:
>    - would it be possible to add convenience methods to LdapObject to
>      access the attribute values directly instead of messing around with
>      the LdapAttributeMap?
> 
>      Something like:
> 
>      /**
>       * Returns all values of the attribute with the given name.
>       */
>      QList<QByteArray> values( const QString &attributeName ) const;
> 
>      /**
>       * Returns the first value of the attribute with the given name
>       * or an empty byte array if the attribute does not exists.
>       */
>      QByteArray value( const QString &attributeName ) const;
> 
It's no problem.

>> And would like to ask, should I invest time in 
>> porting the ldap resource, or that will be replaced by Akonadi somewhen?
> Don't invest time yet, but we'll come back to your offer once the new
> resource API is finished ;)
> 
Ok, then I'll just a small port, to covert from KABC::LdapXXX classes to 
KLDAP::LdapXXX classes, and leave it running with kio_ldap.

> Ciao,
> Tobias
> 
Bye,
György
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]