[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Suspicious code in kdepim-3.5.2 Part 2
From:       Reinhold Kainhofer <reinhold () kainhofer ! com>
Date:       2006-04-19 15:27:36
Message-ID: 200604191727.38898.reinhold () kainhofer ! com
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Samstag, 15. April 2006 18:44 schrieb Christoph Bartoschek:
> - korganizer/koeditorrecurrence.cpp:348
>
> This seems to work but better would be:
> if (day > 0 && day <= 31)

Yeah, a simply (but nasty) typo.

> ------------------------------------
> Problems involving the NULL pointer:
> ------------------------------------
>
> - korganizer/printing/calprinthelper.cpp:194
> If mCalSys is NULL as indicated by line 179, then line 195 crashes.

Wow, your system is quite sophisticated!

mCalSys is initialized in the constructor with mCoreHelper->calendarSystem().
If that is 0, we're in more serious trouble than a simple korganizer crash 
anyway. 
Still I added if (mCalSys) to all other calls, so for consistency I changed it 
here, too.


Thanks again,
Reinhold

- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFERlbqTqjEwhXvPN0RAvqeAKCWIV1OxXXCrdZWxyNPzB8p8YZ7fgCdHjq3
64SHCGodqAxvk95gdhyi3lA=
=01/j
-----END PGP SIGNATURE-----
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]