[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] [PATCH] Do kolab resource work with kitchensync.
From:       Mario Teijeiro Otero <emeteo () escomposlinux ! org>
Date:       2005-09-25 15:04:21
Message-ID: 200509251704.26302.emeteo () escomposlinux ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi,
	I know kitchensync core is going to be deprecated for future versions, but in 
this moment (3.5), kitchensync doesn't work with sync cal resources, because 
this wait for a resourceLoaded( ) signal, and ResourceKolab::doLoad() doesn't 
do.
	There are two choices (among others): adding some property to base class to 
know if a resource is async or sync, or emit the signal. With the attached 
patch a signal is emmited.

	I don't know if there are collateral effects, but I have applied this patch 
for a weeks, and I didn't notice something wrong.

	is it ok for commit?

Regards

P.D.: I need this patch because it's the only way I found to be able sync with 
OpenZaurus PDA.
-- 
Keep away software patents from Europe.
GPG Fingerprint: 7788 5526 6B2A 47BE 9618  8F48 30AB 1CF9 7799 71DC
http://cernicalo.escomposlinux.org	

["kresources-kitchensync.patch" (text/x-diff)]

Index: kresources/kolab/kcal/resourcekolab.cpp
===================================================================
--- kresources/kolab/kcal/resourcekolab.cpp	(revisión: 456008)
+++ kresources/kolab/kcal/resourcekolab.cpp	(copia de trabajo)
@@ -206,7 +206,11 @@
 {
   mUidMap.clear();
 
-  return loadAllEvents() & loadAllTodos() & loadAllJournals();
+  if ( loadAllEvents() & loadAllTodos() & loadAllJournals() ) {
+    emit resourceLoaded( this );
+    return true;
+  }
+  return false;
 }
 
 bool ResourceKolab::doLoadAll( ResourceMap& map, const char* mimetype )
@@ -272,6 +276,7 @@
 
 bool ResourceKolab::doSave()
 {
+  emit resourceSaved( this );
   return true;
   /*
   return kmailTriggerSync( kmailCalendarContentsType )

[Attachment #8 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]