[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Recurrences
From:       Reinhold Kainhofer <reinhold () kainhofer ! com>
Date:       2005-07-03 21:55:28
Message-ID: 200507032355.38588.reinhold () kainhofer ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Am Sonntag, 3. Juli 2005 21:15 schrieb David Jarvie:
> On Sunday 03 Jul 2005 14:51, Reinhold Kainhofer wrote:
> > Am Samstag, 2. Juli 2005 19:54 schrieb David Jarvie:
> > > On Friday 01 Jul 2005 00:39, Reinhold Kainhofer wrote:
> > > Is it really sensible to remove the variants of methods such as
> > > setRecurStart(), durationTo(), etc., which take a 'const QDate&'
> > > parameter. This is a more logical way to do things for recurrences
> > > which float, and also for non-sub-daily recurrence types when you're
> > > really interested in the date rather than the time. For example, to
> > > find the number of recurrences up to and including a certain date, you
> > > would have to call durationTo(QDateTime(date, QTime(23:59:59))
> > > instead of simply
> > >       durationTo(date).
> > > I can't see any real disadvantage of retaining these QDate versions,
> >
> > The API gets bloated by a factor 2. Besides, what's so bad about
> > durationTo(QDateTime(date))?
>
> If you have a non-sub-daily recurrence with a time (i.e. not floating), you
> can't just specify QDateTime(date) for durationTo(), for example. If you
> did, the reply would omit the recurrence on the date you specified, since
> the time in the parameter would default to 00:00:00, when you actually need
> to specify 23:59:59.
>
> > For floating events, the time part will be ignored, so it doesn't matter
> > to what you set it (That's not yet working 100%).
>
> For floating events, I'm not so concerned.

Ah, now I understand. I thought you wanted QDate methods for floating events 
and QDateTime events for all others. That's something I'd like to avoid 
(since the central methods would need to be duplicated, which is sure to 
cause trouble when trying to fix bugs).

Rather, you are talking only about a variant of durationTo, which returns the 
count of the events that occur up to and on the given day. I missed that 
comment in the old .h file. Thanks for pointing this out.

Re-adding that method shouldn't be a problem.

Reinhold
-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna, Austria
email: reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at
 * K Desktop Environment, http://www.kde.org/, KOrganizer / KPilot maintainer

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]