[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Recurrences
From:       Reinhold Kainhofer <reinhold () kainhofer ! com>
Date:       2005-07-03 13:57:53
Message-ID: 200507031557.53901.reinhold () kainhofer ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Am Sonntag, 3. Juli 2005 15:32 schrieb Reinhold Kainhofer:
> Am Samstag, 2. Juli 2005 20:11 schrieb David Jarvie:
> > On Friday 01 Jul 2005 00:39, Reinhold Kainhofer wrote:
> > > Here is the patch for libkcal, which implements recurrences much
> > > better:
> > > http://www.fam.tuwien.ac.at/~reinhold/KOrganizer/RecurrenceRule/
> >
> > In recurrencerule.h, I notice that two members of the class WDayPos (Pos
> > and Day) start with capital letters. As far as I'm aware, this is not
> > normal in KDE or kdepim. Shouldn't they be changed to 'pos' and 'day'?
>
> or to mPos and mDay (according to
> http://korganizer.kde.org/develop/hacking.html). I had it like this before,
> but it looked too ugly to me so I removed the 'm'.
> You're probably right, though, so I'll re-add the 'm'.

I now locally added getter and setter methods (day(), pos() and 
setDay(short),setPos(int)), so this shouldn't be an issue any more.

Cheers,
Reinhold

-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna, Austria
email: reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at
 * K Desktop Environment, http://www.kde.org/, KOrganizer / KPilot maintainer

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]