[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Recurrences
From:       David Jarvie <lists () astrojar ! org ! uk>
Date:       2005-07-02 8:38:08
Message-ID: 200507020938.10376.lists () astrojar ! org ! uk
[Download RAW message or body]

On Friday 01 Jul 2005 00:39, Reinhold Kainhofer wrote:
> Hi guys,
> Here is the patch for libkcal, which implements recurrences much better:
> http://www.fam.tuwien.ac.at/~reinhold/KOrganizer/RecurrenceRule/
>
> I've also created the patches for the affected apps (KAlarm, Kitchensync,
> KMobile, KOrganizer, KPilot and KResources). I haven't been able to test
> them all, but at least they compile ;-)

I won't be able to look at this properly until tomorrow, but here are a few 
random comments in the meantime:

Recurrence::endDate() - this returns a date-time value, so its name isn't very 
intuitive, suggesting as it does that it returns a QDate.

There are some new QPtrList members to hold RecurrenceRules. Given that 
QValueList is more compatible with Qt4, wouldn't it be better to use 
QValueList<RecurrenceRule*> to ease the pending transition?

It looks as if the compat code is being removed. If so, I don't think that it 
should be, since there must be people still using fairly old versions of KDE 
PIM who will benefit from this code when they eventually upgrade.

KAlarm's coding convention is to have no spaces inside round brackets.

The phrase "infinite recursion" occurs a number of times in Doxygen comments. 
It should read "infinite recurrence" (recursion is a different thing).

The spelling "occurence" appears a number of times in Doxygen comments. It 
should be "occurrences".

Cheers,
David.
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]