[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] imap4 locale bug
From:       "=?ýso-8859-9?q?Bar=FD=FE_Metin?=" <baris () uludag ! org ! tr>
Date:       2005-06-26 22:31:38
Message-ID: 200506270131.40647.baris () uludag ! org ! tr
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Thursday 23 June 2005 02:14, Ingo Klöcker wrote:
> Thanks for the patch. I've used a QCString instead of the temporary
> char*.

Thank you.

My friend from Debian reported other problems with tr_TR, with a patch. I've 
tested the attached patch, may I commit?

regards,
-- 
Barýþ Metin

["kdepim-imap4-Turkic-locale-2.patch" (text/x-diff)]

Index: kmail/kmmsgbase.cpp
===================================================================
--- kmail/kmmsgbase.cpp	(revision 429071)
+++ kmail/kmmsgbase.cpp	(working copy)
@@ -14,6 +14,7 @@
 #include <kdebug.h>
 #include <kglobal.h>
 #include <kcharsets.h>
+#include <kasciistringtools.h>
 #include <kmdcodec.h>
 #include <krfcdate.h>
 
@@ -570,7 +571,9 @@
 const QTextCodec* KMMsgBase::codecForName(const QCString& _str)
 {
   if (_str.isEmpty()) return 0;
-  return KGlobal::charsets()->codecForName(_str.lower());
+  QCString codec = QCString(_str);
+  KPIM::kAsciiToLower(codec.data());
+  return KGlobal::charsets()->codecForName(codec);
 }
 
 
@@ -762,8 +765,13 @@
   if (charset == "us-ascii") return toUsAscii(_str);
 
   QCString cset;
-  if (charset.isEmpty()) cset = QCString(kmkernel->networkCodec()->mimeName()).lower();
-    else cset = charset;
+  if (charset.isEmpty())
+  {
+    cset = QCString(kmkernel->networkCodec()->mimeName());
+    KPIM::kAsciiToLower(cset.data());
+  }
+  else cset = charset;
+
   const QTextCodec *codec = codecForName(cset);
   if (!codec) codec = kmkernel->networkCodec();
 
@@ -849,7 +857,10 @@
 
   QCString cset;
   if ( charset.isEmpty() )
-    cset = QCString( kmkernel->networkCodec()->mimeName() ).lower();
+  {
+    cset = QCString( kmkernel->networkCodec()->mimeName() );
+    KPIM::kAsciiToLower( cset.data() );
+  }
   else
     cset = charset;
   const QTextCodec *codec = codecForName( cset );
@@ -968,7 +979,10 @@
     {
        QCString encoding = (*it).latin1();
        if (encoding == "locale")
-          encoding = QCString(kmkernel->networkCodec()->mimeName()).lower();
+       {
+         encoding = QCString(kmkernel->networkCodec()->mimeName());
+         KPIM::kAsciiToLower(encoding.data());
+       }
        if (text.isEmpty())
          return encoding;
        if (encoding == "us-ascii") {
Index: kmail/configuredialog.cpp
===================================================================
--- kmail/configuredialog.cpp	(revision 429071)
+++ kmail/configuredialog.cpp	(working copy)
@@ -74,6 +74,7 @@
 #include <klocale.h>
 #include <kapplication.h>
 #include <kcharsets.h>
+#include <kasciistringtools.h>
 #include <kdebug.h>
 #include <knuminput.h>
 #include <kfontdialog.h>
@@ -715,7 +716,7 @@
   QListViewItem *cur = mTransportList->selectedItem();
   mModifyTransportButton->setEnabled( cur );
   mRemoveTransportButton->setEnabled( cur );
-  mSetDefaultTransportButton->setEnabled( cur ); 
+  mSetDefaultTransportButton->setEnabled( cur );
 }
 
 // adds a number to @p name to make the name unique
@@ -914,7 +915,7 @@
       }
     }
   } else {
-    GlobalSettings::setDefaultTransport( QString::null ); 
+    GlobalSettings::setDefaultTransport( QString::null );
   }
 
   delete item;
@@ -3000,9 +3001,11 @@
   QStringList charsets = composer.readListEntry( "pref-charsets" );
   for ( QStringList::Iterator it = charsets.begin() ;
         it != charsets.end() ; ++it )
-      if ( (*it) == QString::fromLatin1("locale") )
-        (*it) = QString("%1 (locale)")
-          .arg( QCString( kmkernel->networkCodec()->mimeName() ).lower() );
+    if ( (*it) == QString::fromLatin1("locale") ) {
+      QCString cset = QCString( kmkernel->networkCodec()->mimeName() );
+      KPIM::kAsciiToLower( cset.data() );
+      (*it) = QString("%1 (locale)").arg( cset );
+    }
 
   mCharsetListEditor->setStringList( charsets );
   mKeepReplyCharsetCheck->setChecked( !composer.readBoolEntry( "force-reply-charset", false ) );

[Attachment #8 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]