[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Build fix for KMail with GCC 4.
From:       Michael Pyne <pynm0001 () comcast ! net>
Date:       2005-06-21 1:07:38
Message-ID: 200506202107.40024.pynm0001 () comcast ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


KMail has failed to build for weeks for me now.  I thought I had tracked it 
down yesterday but that turned out to be just another problem. :-/

Anyways, the following patch to popaccount.h fixes the problem for me.  It's 
actually kind of interesting, PopAccount is declared in the KMail namespace, 
and the KMAcctMgr class is declared elsewhere without a namespace.

Apparently gcc <= 3.4 would put the "friend class KMAcctMgr" declaration in 
the global namespace in this situation, but gcc 4 places it in the enclosing 
namespace (KMail in this case), leading to compile errors later.

I'm not sure which one is correct, but I suppose it pays to be overly 
cautious. :-/

I would apply myself but I can't test on 3.x.

If you need to contact me about the patch please CC: me, I'm not subscribed to 
this mailing list.

Regards,
 - Michael Pyne

Index: popaccount.h
===================================================================
--- popaccount.h        (revision 427263)
+++ popaccount.h        (working copy)
@@ -97,7 +97,7 @@

 protected:
   enum Stage { Idle, List, Uidl, Head, Retr, Dele, Quit };
-  friend class KMAcctMgr;
+  friend class ::KMAcctMgr;
   friend class KMPasswdDialog;
   PopAccount(KMAcctMgr* owner, const QString& accountName, uint id);


[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]