[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Group schedulling when an event is moved in the
From:       Mario Teijeiro Otero <emeteo () escomposlinux ! org>
Date:       2004-12-28 0:03:15
Message-ID: 200412280103.23593.emeteo () escomposlinux ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


El Thursday, 23 de December de 2004 12:32, Reinhold Kainhofer escribió:
> Am Donnerstag, 23. Dezember 2004 01:37 schrieb Mario Teijeiro Otero:
> >  It was not easy make it. The blame is the  $%&·$%%/
> > sendIcalMessage in IncidenceChanger::changeIncidence.
>
> Yes... Do you have any better suggestion to clean this up once and for all
> ?
>
> >  Problem: the MessageBox has not parent widget
>
> Shall we add an additional QWidget* parameter to all IncidenceChanger
> methods, so the message box has a parent?
>
> >  the agenda
> > recives the move events and KOAgenda->performItemAction and
> > KOAgenda->endItemAction has not ready to be reentrant. I fixed this.
>
> Actually endItemAction should never be called twice... True,
> performItemAction should be reentrant.

Drag a recurrent event with attendees,and when korganizer asks you 
to send a message to the attendeess, move the pointer over the agenda, "the 
item" follows it, and if you do a click endItemAction can be called. I thing 
this is because sendIcalMessage has not a widget parent.

> >  We don't have enough control when show the MessageBox to ask the user
> > if wants to send a status update, This control is required because when
> > We move a recurrente event with "Only this item",
> > mChanger->changeIncidence and mChanger->addIncidence are called, this
> > calls fire a "ask user update event" each one.
>
> Yes. We need to send two mails anyway (one changing the recurring event,
> and one adding the newly dissociated item), since an invitation allows only
> one event per mail...

Send two mails it is right ([1] althoug I was reading rfc2446 and I have a 
doubt ), but to ask to the user twice..., I think it's wrong.
Perhaps an emit enableGroupwareCommunication(false) and 
enableGroupwareCommunication(true) as emit enableAgendaUpdate(...) is used, 
and to have an interface to handle GroupwareCommunication when the manage of 
this was not trivial should simplify this.


> I wish there was a simpler way to achieve this. Then we could get rid of
> all those nasty hacks in the agenda. Maybe you have a good idea to achieve
> this?

 See 1.) see below for my doubt ;-)

> I haven't tested your patch, but I guess you have done that yourself. I saw
> you moved the emit beginMultiModify. Have you checked that undoing still
> works (i.e. the modification of the old and the addition of hte new item
> are bundled together to one undo item, in both dissociation cases)?

I tested it, and I think undoing works right.

> Apart from that I don't see any obvious problems.
>
> Reinhold
>
> PS: I'll  be at home with my parents for the next few days, where my
> internet access will only be through a slow dialup connection using
> Windows... So I won't be able to commit/fix anything in CVS, and I also
> won't be able to improve the groupware resources.

Ok, I'll wait until you can to come back to repair a my posible break ;-).


[1] In Page 78 of RFC2446, there are mention about a RECURRENCE-ID when a 
"instance of a recurrence" is modified. As far as I could understand, when 
one item that belongs to a recurrent event is modified, the recurrent event 
is not touched, only a new event is created:
	* the UID is the same that the recurrent but with the datetime that define 
the item as RECURRENCE-ID.
	*The sequence number is incremented ( see the examples ). 

I don't know yet if our libkcal can handle RECURRENCE-ID.


Regards.

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]