--===============1859763253==
Content-Type: multipart/signed;
  boundary="nextPart1432013.YbyHVAhVrN";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1432013.YbyHVAhVrN
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Am Donnerstag, 23. Dezember 2004 01:37 schrieb Mario Teijeiro Otero:
>  It was not easy make it. The blame is the  $%&=B7$%%/
> sendIcalMessage in IncidenceChanger::changeIncidence.

Yes... Do you have any better suggestion to clean this up once and for all ?


>  Problem: the MessageBox has not parent widget=20

Shall we add an additional QWidget* parameter to all IncidenceChanger metho=
ds,=20
so the message box has a parent?


>  the agenda=20
> recives the move events and KOAgenda->performItemAction and
> KOAgenda->endItemAction has not ready to be reentrant. I fixed this.

Actually endItemAction should never be called twice... True, performItemAct=
ion=20
should be reentrant.

>  We don't have enough control when show the MessageBox to ask the user
> if wants to send a status update, This control is required because when We
> move a recurrente event with "Only this item", mChanger->changeIncidence
> and mChanger->addIncidence are called, this calls fire a "ask user update
> event" each one.

Yes. We need to send two mails anyway (one changing the recurring event, an=
d=20
one adding the newly dissociated item), since an invitation allows only one=
=20
event per mail...


>  I don't like very much this patch because looks a "patch".

Moving and dissociating in the agenda is a nasty beast. Mainly, because it =
can=20
get so complex, and so many different cases can appear.
In particular, when dissociating, ideally we would just change the incidenc=
e=20
in the calendar and let changeIncidenceDisplay handle it. However, the=20
problem is that the currently selected agenda item (which we work on using =
a=20
pointer ) is dissociated and so would be deleted and recreated as a new=20
item.But we still have the pointer to the old agenda item, and we keep=20
working on it (setting the time to the new position in the agenda). =3D> KO=
rg=20
would crash.
That's the reason why I preserve the agenda item, and just replace the poin=
ter=20
to the incidence with the newly created one. After that, the times can be=20
adjusted to the new position of that agenda item.=20
I wish there was a simpler way to achieve this. Then we could get rid of al=
l=20
those nasty hacks in the agenda. Maybe you have a good idea to achieve this?

I haven't tested your patch, but I guess you have done that yourself. I saw=
=20
you moved the emit beginMultiModify. Have you checked that undoing still=20
works (i.e. the modification of the old and the addition of hte new item ar=
e=20
bundled together to one undo item, in both dissociation cases)?

Apart from that I don't see any obvious problems.

Reinhold

PS: I'll  be at home with my parents for the next few days, where my intern=
et=20
access will only be through a slow dialup connection using Windows... So I=
=20
won't be able to commit/fix anything in CVS, and I also won't be able to=20
improve the groupware resources.

=2D-=20
=2D-----------------------------------------------------------------
Reinhold Kainhofer, Vienna, Austria
email: reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at
 * K Desktop Environment, http://www.kde.org/, KOrganizer / KPilot maintain=
er

--nextPart1432013.YbyHVAhVrN
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBByqzUTqjEwhXvPN0RAhIlAJ4zkUDDnxpgGFCGrluPRTCZ25V+0wCgtPPT
cDaS4MupOg+jCs8mWfjaihc=
=t+/E
-----END PGP SIGNATURE-----

--nextPart1432013.YbyHVAhVrN--

--===============1859763253==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
--===============1859763253==--