[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Suppressing KMail's KTipDialog invocation when in
From:       Allen Winter <winter () kde ! org>
Date:       2004-11-23 23:36:21
Message-ID: 200411231836.21454.winter () kde ! org
[Download RAW message or body]

On Tuesday 23 November 2004 12:18 pm, Will Stephenson wrote:
> Hi All
> 
> There's a bug where KTipDialog appears, but empty on kontact start.  This is 
> because this time it's not Kontact showing the tips, with a list of all the 
> components' tips files, but KMail, which likes to show its tips when 
> constructing its KMainWidget.  Since KMail is running in Kontact, its appname 
> is kontact, and kontact/tips does not exist -> empty tips dialog.
> 
> These patches correct this, by suppressing KMail's startup tips when it is not 
> running standalone.
> 
> This one suppresses the tip whenever kmail is not running with appname 
> "kmail":
> http://www.stevello.free-online.co.uk/kdepim-tips-in-kontact.diff
> 
> This one (Till's suggestion) moves the tip invocation to KMainWin instead of 
> KMainWidget, so it is only called when running standalone:
> 
> http://www.stevello.free-online.co.uk/kdepim-tips-in-kontact2.diff
> 
> Can you see any problems with #2 - is there a case where we would want to run 
> KMail as a part, but show its own tips?
> 
> Will
> 
> PS - if you never see any tips, that's because of tip rate limiting code in 
> KTipDialog.  Edit appnamerc so it contains something like this: 
> 
> [TipOfDay]
> TipLastShown=2003,11,23,13,38,31

Will,

I just wanted to say Thanks for finding and fixing this bug.   I looked at it myself quickly a couple times
but I assumed the problem was in the tips file.  I never bothered to examine the source code.

One minor nit: In the future could you send small patches like this as attachments rather than URLs please.
Regards,
Allen

-- 
Let's Keep the Political Talk Out of KDE PLEASE
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]