[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim][PATCH]  Zoom on korganizer view.
From:       Bram Schoenmakers <bram_s () softhome ! net>
Date:       2004-09-28 11:23:34
Message-ID: 200409281323.34918.bram_s () softhome ! net
[Download RAW message or body]

Mario Teijeiro Otero! We've been expecting you...
> El Sunday 26 September 2004 13:29, Bram Schoenmakers escribió:
>
> I think that I can be able to  Horizontal and vertical zoom (ctrl+wheel
> and shitf+wheel). The Horizontal zoom works that you suggest me.
>
>
> I'm not sure if the use of static variable is ok on kde style code, please
> Can you have a look on KOAgendaView::ZoomView ?
>
>
> I think that I fix a bug. If the Hour size is changed on the configure
> window, the QScrollView doesn't resize until the program is restarted (this
> cause that sometimes, the last hours of a day can't be acceded. I fix this
> with a resizeContents(width,height) on KOAgenda::updateConfig().
> is It necessary to report this bug on Bugzilla ?

Hi Mario,

Neat. Just what I expected :)

A small nitpicky thingy: according to the code style guide you have to place 
{ on the same line as 'if'.

One problem: Someone has to approve the patch. My words don't mean that much 
when it comes to applying the patch. I see you don't have a CVS-account, so 
I'll take care of committing it once it's approved.

Kind regards,

-- 
Bram Schoenmakers
http://home.wanadoo.nl/bram_s
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]