[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Kolab bugfix: Allow completion of names even
From: Karl-Heinz Zimmer <khz () kde ! org>
Date: 2004-08-13 23:20:38
Message-ID: 200408140120.46646 () postmaster ! bugcops ! org
[Download RAW message or body]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Samstag, 14. August 2004 00:21 schrieb Ingo Klöcker:
> On Thursday 12 August 2004 11:25, Karl-Heinz Zimmer wrote:
> > Am Donnerstag, 12. August 2004 00:15 schrieb Ingo Klöcker:
> > > Instead of adding duplicates to the completion list the code which
> > > looks for valid completions should be changed to not only find
> > > addresses that start with the already entered characters, but to
> > > find addresses which contain a word which starts with the
> > > characters. Then we would complete by first name, by last name, by
> > > email address and by the domain part of email addresses.
> >
> > Ingo, I agree that this would be better.
> >
> > Do you think you still could agree to adding the patch (for now)
> > since it solves the most common aspect of the problem?
>
> Does the patch really work correctly?
I asked for peer review.
Did you test my code?
I did and it works here in most cases.
> Does fullEmail always return the
> email address in the form
> firstname lastname <email@address>
> or
> "firstname lastname" <email@address>
> but never in the form
> "lastname, firstname" <email@address>
> or
> "firstname" lastname <email@address>
> ?
Not always, sorry.
> Why don't you simply build the alternative address from
> addr.firstName(), addr.lastName() and addr.email() instead
> of tearing apart addr.fullEmail() and reassembling it in
> different order?
Because there is no content in addr.firstName() / addr.lastName()
in most cases here.
> For the time being I'm okay with adding the alternative addresses
> to the completion list, but I'm not okay with the hackish way the
> alternative address is created.
I will happily accept if you find a better way of solving this issue.
Cheers
Karl-Heinz
- --
Karl-Heinz <mailto:khz@indeview.org> <mailto:khz@kde.org>
Zimmer I n d e V i e w K D E
Föhren Presentations Beyond Limitations Conquer your Desktop
www.fiehr.de www.indeview.org www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQFBHUzOCcaVnbvggDcRAmpOAKDtDDs0IIY1JJitePxi2SX8swxR3wCfbB4H
/gbZVWR4YRCtOqfdDyZyklY=
=xAhB
-----END PGP SIGNATURE-----
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic