--===============1558235736== Content-Type: multipart/signed; boundary="nextPart1472600.8DreRnW4RY"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart1472600.8DreRnW4RY Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 23 July 2004 01:58, David Faure wrote: > On Friday 23 July 2004 01:46, Ingo Kl=C3=B6cker wrote: > > Even if it works with KDE 3.3 (which is hard to believe because > > kurldrag has absolutely nothing to do with the selection clipboard) > > I don't see what makes you think that. > > void KHTMLPopupGUIClient::slotCopyLinkLocation() > { > // Set it in both the mouse selection and in the clipboard > KURL::List lst; > lst.append( d->m_url ); > QApplication::clipboard()->setSelectionMode(true); > QApplication::clipboard()->setData( new KURLDrag( lst ) ); > QApplication::clipboard()->setSelectionMode(false); > QApplication::clipboard()->setData( new KURLDrag( lst ) ); > } > > Seems quite obvious to me that a KURLDrag is used when using "copy > link location", both in selection and normal clipboard. Well, this just means that it works if one uses KHTML to copy a mailto:=20 URL to the clipboard. Can you guarantee that all other applications do=20 it the same way? FWIW, KMail uses if (mUrl.protocol() =3D=3D "mailto") { // put the url into the mouse selection and the clipboard QString address =3D KMMessage::decodeMailtoUrl( mUrl.path() ); clip->setSelectionMode( true ); clip->setText( address ); clip->setSelectionMode( false ); clip->setText( address ); if (mMainWidget) mMainWidget->statusMsg( i18n( "Address copied to clipboard." )); } else { // put the url into the mouse selection and the clipboard clip->setSelectionMode( true ); clip->setText( mUrl.url() ); clip->setSelectionMode( false ); clip->setText( mUrl.url() ); if ( mMainWidget ) mMainWidget->statusMsg( i18n( "URL copied to clipboard." )); } As you can see KURLDrag is not involved. > > it doesn't work with KDE 3.2. Since the patch doesn't hurt it > > should still be applied. > > If you want. But a dozen of other combinations will still be broken: > * drag-n-drop of an email from kmail's readerwin to konsole - or any > text editor=20 > * RMB/"copy link location" in kmail / konqueror, MMB in=20 > kmail / kaddressbook / anywhere else. Adding a hack for the "pasting > to kaddressbook" case doesn't help with all the other places where > you can paste the data. It's much cleaner to fix the source (the code > that copies the data) rather than fixing the destination (each and > every lineedit!). RMB/"copy link location" in KMail doesn't put a mailto-URL in the=20 clipboard (see above). So obviously pasting afterwards will always=20 work. And MMB in KMail's address fields also works because I've fixed=20 KPIM::AddresseeLineEdit. Actually I think we should probably use=20 KPIM::AddresseeLineEdit in KAddressBook (in EmailEditWidget) instead of=20 a simple KLineEdit. Regards, Ingo --nextPart1472600.8DreRnW4RY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQBBAXMIGnR+RTDgudgRAu8gAKCAkh14K1CKo0JjgzVt01/LeupuLgCfeGJ/ FzV2xQP+tIuqnVI0ar+vCcE= =DPBo -----END PGP SIGNATURE----- --nextPart1472600.8DreRnW4RY-- --===============1558235736== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-pim mailing list kde-pim@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-pim kde-pim home page at http://pim.kde.org/ --===============1558235736==--