[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] kdeaddons
From:       Frans Englich <frans.englich () telia ! com>
Date:       2004-07-19 2:51:39
Message-ID: 20040719025139.574CB99E0 () office ! kde ! org
[Download RAW message or body]

CVS commit by englich: 

Avoid leaking KAboutData by using the new KCModule::setAboutData() function.

Can kdeaddons/kontact/plugins/newsticker/kcmkontactknt.{cpp,h} be fixed(depend on \
kdelibs HEAD)? 

CCMAIL: kde-pim@mail.kde.org


  M +6 -12     konq-plugins/kuick/kcmkuick/kcmkuick.cpp   1.17
  M +0 -1      konq-plugins/kuick/kcmkuick/kcmkuick.h   1.5
  M +9 -13     vimpart/kcmvim/kcmvim.cpp   1.18
  M +0 -1      vimpart/kcmvim/kcmvim.h   1.5


--- kdeaddons/vimpart/kcmvim/kcmvim.cpp  #1.17:1.18
@@ -40,4 +40,13 @@ KCMVim::KCMVim(QWidget *parent, const ch
 : KCModule(KCMVimFactory::instance(), parent, name)
 {
+        KAboutData *about =
+                new KAboutData(I18N_NOOP("kcmvim"), I18N_NOOP("KDE Vim Embedding \
Control Module"), +                                "1.0", I18N_NOOP("The Vim KPart is \
developed by the KVim Team."), KAboutData::License_GPL, +                             \
"(c) 2002-2003 Mickael Marchand", +                                \
0,"http://freehackers.org/kvim"); +
+        about->addAuthor("Mickael Marchand", "http://freenux.org", \
"marchand@kde.org"); +        setAboutData( about );
+
         //init values
         configurationok = haseval = hasclientserver = false;
@@ -282,16 +291,3 @@ void KCMVim::setModified()
 }
 
-const KAboutData* KCMVim::aboutData() const
-{
-        KAboutData *about =
-                new KAboutData(I18N_NOOP("kcmvim"), I18N_NOOP("KDE Vim Embedding \
                Control Module"),
-                                "1.0", I18N_NOOP("The Vim KPart is developed by the \
                KVim Team."), KAboutData::License_GPL,
-                                "(c) 2002-2003 Mickael Marchand",
-                                0,"http://freehackers.org/kvim");
-
-        about->addAuthor("Mickael Marchand", "http://freenux.org", \
                "marchand@kde.org");
-
-        return about;
-}
-
 #include "kcmvim.moc"

--- kdeaddons/vimpart/kcmvim/kcmvim.h  #1.4:1.5
@@ -52,5 +52,4 @@ class KCMVim : public KCModule
                                 vimbase *base;
 
-                                const KAboutData* aboutData() const;
 
                 protected slots:

--- kdeaddons/konq-plugins/kuick/kcmkuick/kcmkuick.cpp  #1.16:1.17
@@ -37,4 +37,10 @@ KCMKuick::KCMKuick(QWidget *parent, cons
 :KCModule(parent, name)
 {
+    KAboutData *ab=new KAboutData( "kcmkuick", I18N_NOOP("KCM Kuick"),
+       "0.2",I18N_NOOP("KControl module for Kuick's configuration"), \
KAboutData::License_GPL, +       "(c) 2001, Holger Freyther", 0, 0, \
"freyther@kde.org"); +    ab->addAuthor("Holger Freyther",0, "freyther@kde.org");
+    setAboutData( ab );
+
     QVBoxLayout *topLayout = new QVBoxLayout(this, 0, 0);
     dialog = new KCMKuickDialog(this);
@@ -147,15 +153,3 @@ QString KCMKuick::quickHelp() const
 }
 
-const KAboutData * KCMKuick::aboutData() const
-{
-
- KAboutData *ab=new KAboutData( "kcmkuick", I18N_NOOP("KCM Kuick"),
-    "0.2",I18N_NOOP("KControl module for Kuick's configuration"), \
                KAboutData::License_GPL,
-    "(c) 2001, Holger Freyther", 0, 0, "freyther@kde.org");
-
-  ab->addAuthor("Holger Freyther",0, "freyther@kde.org");
- return ab;
-
-}
-
 #include "kcmkuick.moc"

--- kdeaddons/konq-plugins/kuick/kcmkuick/kcmkuick.h  #1.4:1.5
@@ -34,5 +34,4 @@ public:
         void defaults();
         QString quickHelp() const;
-        virtual const KAboutData * aboutData() const;
 public slots:
         void configChanged();


_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]