[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] New widget: KDatePickerPopup
From:       Allen Winter <winterz () verizon ! net>
Date:       2004-03-20 18:15:01
Message-ID: 200403201315.02108.winterz () verizon ! net
[Download RAW message or body]

On Saturday 20 March 2004 12:57 pm, Zack Rusin wrote:
> On Saturday 20 March 2004 06:55, Bram Schoenmakers wrote:
> > What I sent was not the final version. The basics are written now.
> > I'm busy with documenting it. The file I've sent was a sketch, just
> > showing the functionality. I'm glad some people are welcoming this
> > feature, so I know I can invest more time in it. I'll fix the points
> > you've listed there, I guess it'll be finished on Sunday.
> 
> Don't get me wrong. You did a wonderful job. What does irritate me a lot 
> is completely not related to you but to the "quality team" which did 
> exactly the opposite of what it was supposed to do here.
> 

You are correct, and I apologize.

The author asked for the commit.
I asked if it was ok with Cornelius, he said "yes" but make sure to test.
I tested in my sandbox.  It worked ok.
I committed.

I never thought to look at coding style and practices.
Cornelius also said it was ok to add docs later.

From now on I will pay more attention to the coding style and the like.

Regards,
Allen

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]