[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Server-based resources and editing events
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2004-02-11 13:12:55
Message-ID: 200402111412.55099.schumacher () kde ! org
[Download RAW message or body]

On Wednesday 11 February 2004 13:00, Best, Jan-Pascal van wrote:
>
> But I can think of a combination: keep a list of "dirty" events, and write
> them to the server at endChange(). We just need to make sure that
> endChange() is called properly.

Yes, exactly.

> OK, we'll keep those for now. As optimisation, you mean e.g. to pass a list
> of added/modified/deleted events? I can imagine some cases for which some
> GUI flicker could be reduced. We can change that later.

Yes.

> > eventDeleted() is tricky, because you have to make sure that
> > the event
> > actually isn't deleted when the signal is sent, because the event
> > object is passed as argument.
>
> Should I rename it to eventToBeDeleted()?

Sounds good.

> > I really don't like the eventChanged() function because it's
> > redundant.
> > The Calendar holds a pointer to the event object. When the object is
> > changed by the GUI it actually is also changed for the resource.
> > Requiring to separately notify this change doesn't feel right
> > to me. If you don't do it you will get inconsistencies.
>
> I don't think it is redundant, since merely changing the event object in
> memory does not tell the resource that the event has changed: to find that
> out it would have to iterate over all (possible 1000s of) events and
> compare them all with *copies* to see if something changed.

That's why we have the IncidenceObserver. With that it's no problem.

> But since the same functionality can be had (hopefully) with a combination
> of begin/endChange() and IncidenceObserver, I'll try and use that.

Great.

-- 
Cornelius Schumacher <schumacher@kde.org>
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]