[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Patch Bug libkcal + Outlook
From:       Marc TAIEB <TAIEBMA () e-i ! com>
Date:       2003-11-25 18:05:36
[Download RAW message or body]

Hi,

I think I have found a bug in libkcal :
The function addIncidence in "calendarimap/ersourceimap.cpp" is missing the 
uid param that is pass by kmail via dcop.

In kmail (imap mode) :
When you create un Event, kmail receive the ical via dcop and then create a 
mail in the Calendar imap folder. I propose to put the summary of the ical in 
the subject field. Because, I don't know why, but Outlook display the subject 
of the mail header.

What do you think about ?

Regards


Marc TAIEB
Euro Information Developpement
Subsidiary Company of CreditMutuel
Email : taiebma@e-i.com

["patch-libkcal" (text/x-diff)]

Index: calendarimap/resourceimap.cpp
===================================================================
RCS file: /home/taiebma/kde/cvsroot/kdepim/libkcal/calendarimap/resourceimap.cpp,v
retrieving revision 1.25
diff -U2 -r1.25 resourceimap.cpp
--- calendarimap/resourceimap.cpp	20 Nov 2003 07:11:07 -0000	1.25
+++ calendarimap/resourceimap.cpp	25 Nov 2003 17:49:03 -0000
@@ -491,8 +491,8 @@
 }
 
-bool ResourceIMAP::addIncidence( const QString& type, const QString& ical )
+bool ResourceIMAP::addIncidence( const QString& type, const QString& uid, const QString& ical )
 {
-  // kdDebug() << "ResourceIMAP::addIncidence( " << type << ", "
-  //           << /*ical*/"..." << " )" << endl;
+  kdDebug() << "ResourceIMAP::addIncidence( " << type << ", "
+             << /*ical*/"..." << " )" << ical << endl;
   Incidence* i = parseIncidence( ical );
   if ( !i ) return false;
Index: calendarimap/resourceimap.h
===================================================================
RCS file: /home/taiebma/kde/cvsroot/kdepim/libkcal/calendarimap/resourceimap.h,v
retrieving revision 1.20
diff -U2 -r1.20 resourceimap.h
--- calendarimap/resourceimap.h	24 Oct 2003 13:47:46 -0000	1.20
+++ calendarimap/resourceimap.h	25 Nov 2003 17:49:03 -0000
@@ -51,5 +51,5 @@
 
   k_dcop:
-    virtual bool addIncidence( const QString& type, const QString& ical );
+    virtual bool addIncidence( const QString& type, const QString& uid, const QString& ical );
     virtual void deleteIncidence( const QString& type, const QString& uid );
     virtual void slotRefresh( const QString& type );

["patch-kmail" (text/x-diff)]

Index: kmailicalifaceimpl.cpp
===================================================================
RCS file: /home/taiebma/kde/cvsroot/kdepim/kmail/kmailicalifaceimpl.cpp,v
retrieving revision 1.24
diff -U2 -r1.24 kmailicalifaceimpl.cpp
--- kmailicalifaceimpl.cpp	20 Nov 2003 07:09:45 -0000	1.24
+++ kmailicalifaceimpl.cpp	25 Nov 2003 17:51:02 -0000
@@ -79,5 +79,8 @@
   msg->setHeaderField("Content-Type",
 		      "text/calendar; method=REQUEST; charset=\"utf-8\"");
-  msg->setSubject( uid );
+  int pos = ical.find("SUMMARY:");
+  int endpos = ical.find('\n', pos);
+  msg->setSubject( ical.mid(pos + 8, endpos - pos - 8) );
+//  msg->setSubject( uid );
   msg->setTo( msg->from() );
   msg->setBodyEncoded( ical.utf8() );


_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]