[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] [PATCH] Make Report Bug working with SummaryView
From:       Tobias Koenig <tokoe () kde ! org>
Date:       2003-11-24 20:57:21
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi,

the attached patch fixes http://bugs.kde.org/show_bug.cgi?id=68967 by
using the correct appName in the aboutData.

Ok for commit?

Ciao,
Tobias
-- 
Can a government that shoots at reporters be democratic?
Separate politics from religion and economy!

["summaryview_bugzilla.patch" (text/plain)]

Index: summaryview_part.cpp
===================================================================
RCS file: /home/kde/kdepim/kontact/plugins/summary/summaryview_part.cpp,v
retrieving revision 1.28
diff -p -u -b -r1.28 summaryview_part.cpp
--- summaryview_part.cpp	21 Nov 2003 19:04:33 -0000	1.28
+++ summaryview_part.cpp	24 Nov 2003 20:54:59 -0000
@@ -60,12 +60,13 @@ namespace Kontact
 }
 
 SummaryViewPart::SummaryViewPart( Kontact::Core *core, const char *widgetName,
+                                  const KAboutData *aboutData,
                                   QObject *parent, const char *name )
   : KParts::ReadOnlyPart( parent, name ),
     mCore( core ), mOptionsDialog( 0 )
 {
   mStatusExt = new KParts::StatusBarExtension( this );
-  setInstance( new KInstance( "kontactsummary" ) ); // ## memleak
+  setInstance( new KInstance( aboutData ) );
 
   QScrollView *sv = new QScrollView( core );
 
Index: summaryview_part.h
===================================================================
RCS file: /home/kde/kdepim/kontact/plugins/summary/summaryview_part.h,v
retrieving revision 1.14
diff -p -u -b -r1.14 summaryview_part.h
--- summaryview_part.h	16 Nov 2003 22:03:43 -0000	1.14
+++ summaryview_part.h	24 Nov 2003 20:54:59 -0000
@@ -51,6 +51,7 @@ class SummaryViewPart : public KParts::R
 
   public:
     SummaryViewPart( Kontact::Core *core, const char *widgetName,
+                     const KAboutData *aboutData,
                      QObject *parent = 0, const char *name = 0 );
     ~SummaryViewPart();
 
Index: summaryview_plugin.cpp
===================================================================
RCS file: /home/kde/kdepim/kontact/plugins/summary/summaryview_plugin.cpp,v
retrieving revision 1.12
diff -p -u -b -r1.12 summaryview_plugin.cpp
--- summaryview_plugin.cpp	24 Sep 2003 12:15:38 -0000	1.12
+++ summaryview_plugin.cpp	24 Nov 2003 20:54:59 -0000
@@ -43,14 +43,14 @@ SummaryView::~SummaryView()
 
 KParts::Part *SummaryView::createPart()
 {
-  return new SummaryViewPart( core(), "summarypartframe", this,
-                              "summarypart" );
+  return new SummaryViewPart( core(), "summarypartframe", aboutData(),
+                              this, "summarypart" );
 }
 
 const KAboutData *SummaryView::aboutData()
 {
   if ( !mAboutData ) {
-    mAboutData = new KAboutData( "summaryview", I18N_NOOP("Kontact Summary"),
+    mAboutData = new KAboutData( "kontact/summary", I18N_NOOP("Kontact Summary"),
                                  "0.1",
                                  I18N_NOOP("Kontact Summary View"),
                                  KAboutData::License_LGPL,

["signature.asc" (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]