[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] [PATCH] 2 leak fixes in korganizer and 2 leak fixes in
From:       "ismail 'cartman' =?iso-8859-1?q?d=F6nmez?=" <ismail.donmez () boun ! edu ! tr>
Date:       2003-11-21 17:27:08
[Download RAW message or body]

Hi,

Valgrind output and proposed patches . Please review :

P.S : Now there is only *one* KDE related leak on korganizer which seems to be 
kresources related,  though Xft,XCursor,Qt leaks like hell still ;) ... 

==10784== 92 bytes in 1 blocks are possibly lost in loss record 200 of 347
==10784==    at 0x4002BDC2: operator new(unsigned) (vg_replace_malloc.c:162)
==10784==    by 0x40305DEF: CalendarView::setCalendar(KCal::Calendar*) 
(calendarview.cpp:294)
==10784==    by 0x40384C22: ActionManager::createCalendarResources() 
(actionmanager.cpp:169)
==10784==    by 0x8052183: KOrganizer::init(bool) (korganizer.cpp:118)
==10784==


--> Fixed by calendarview_leak.patch

==10784== 8 bytes in 1 blocks are definitely lost in loss record 36 of 347
==10784==    at 0x4002BDC2: operator new(unsigned) (vg_replace_malloc.c:162)
==10784==    by 0x40669B52: KCal::CalendarResources::init()
(calendarresources.cpp:111)
==10784==    by 0x406697E3:
KCal::CalendarResources::CalendarResources(QString const&)
(calendarresources.cpp:80)
==10784==    by 0x40377FC1: KOCore::calendarResources() (kocore.cpp:313)
==10784==
==10784==
==10784== 12 bytes in 1 blocks are definitely lost in loss record 49 of 347
==10784==    at 0x4002BDC2: operator new(unsigned) (vg_replace_malloc.c:162)
==10784==    by 0x40669B7E: KCal::CalendarResources::init()
(calendarresources.cpp:112)
==10784==    by 0x406697E3:
KCal::CalendarResources::CalendarResources(QString const&)
(calendarresources.cpp:80)
==10784==    by 0x40377FC1: KOCore::calendarResources() (kocore.cpp:313)
==10784==
==10784==


--> Fixed by calendarresources_leak.patch ( similar leak is in 
calendarresources.cpp line 112 too . Patch fixes both . )

==22987== 196 bytes in 1 blocks are definitely lost in loss record 241 of
338
==22987==    at 0x4002BDC2: operator new(unsigned) (vg_replace_malloc.c:162)
==22987==    by 0x403407CE: KOEventEditor::processInput()
(koeventeditor.cpp:263)
==22987==    by 0x4033E406: KOIncidenceEditor::slotOk()
(koincidenceeditor.cpp:110)
==22987==    by 0x40D108C6: KDialogBase::qt_invoke(int, QUObject*) (in
/opt/kde/lib/libkdeui.so.4.2.0)
==22987==


--> Fixed by koeventeditor_leak.patch


-- 
For whatever reason done Terror just sucks







["calendarresources_leak.patch" (text/x-diff)]

--- kdepim/libkcal/calendarresources.cpp.~1.35.~	2003-11-10 10:31:46.000000000 +0200
+++ kdepim/libkcal/calendarresources.cpp	2003-11-21 18:55:35.000000000 +0200
@@ -122,6 +122,8 @@
 
   close();
 
+  delete mStandardPolicy;
+  delete mAskPolicy;
   delete mManager;
 }
 

["calendarview_leak.patch" (text/x-diff)]

--- kdepim/korganizer/calendarview.cpp.~1.230.~	2003-11-03 19:29:22.000000000 +0200
+++ kdepim/korganizer/calendarview.cpp	2003-11-21 18:34:31.000000000 +0200
@@ -282,6 +282,7 @@
 
   delete mDialogManager;
   delete mViewManager;
+  delete mHistory;
 
   kdDebug(5850) << "~CalendarView() done" << endl;
 }

["koeventeditor_leak.patch" (text/x-diff)]

--- kdepim/korganizer/koeventeditor.cpp.~1.63.~	2003-11-18 20:45:23.000000000 +0200
+++ kdepim/korganizer/koeventeditor.cpp	2003-11-21 19:09:46.000000000 +0200
@@ -55,6 +55,7 @@
 KOEventEditor::~KOEventEditor()
 {
   emit dialogClose( mEvent );
+  delete mEvent;
 }
 
 void KOEventEditor::init()


_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]