[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] KOrganizer
From:       Tobias Koenig <tokoe () kde ! org>
Date:       2003-08-03 23:06:05
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Mon, Aug 04, 2003 at 12:22:48AM +0200, Reinhold Kainhofer wrote:
> On Sunday 03 August 2003 19:28, Tobias Koenig wrote:
Hi Reinhold,

> > the attached patch adds rounded corners to the koagendaitems and a ical
> > like frame style.
> 
> Is there any particular reason why you want to change the look of korganizer 
> again, after the last change by Tim?
Well, I thought rounded corners fits much better to the keramik style
than this rectangular items.
If the majority objects, I've no problem with omitting the patch.

> Also if an event starts at 8 am then it starts there, so why should its 
> borders be rounded so its start isn't so clear-cut visually any more.
The top of the item is still at the 8am line of the grid, so it should
still be visible.

> In contrast, the old cornered boxes really filled the time the event 
> allocated, so it looked like that time was absolutely filled, and there is no 
> time between two successive events.
Ok, but this is a quite subjective perception, isn't it?
I mean the apple guys have done a lot of usability tests and they use
round corners as well. I don't want to copy the mac style, but from the
usability point of view we can learn a lot from the apply guys.

> > Any other objections or suggestions?
> 
> Yes, take very short events (and don't set the hour too large, otherwise you 
> don't see the problem). The really great thing about Tim's patch was that it 
> detected short events and in that case didn't print the time span header. 
Right, but IMHO it is really annoying when the header disappears for
short events. Shouldn't be there the standard header with a tooltip
which contains the event text?

> You, however, just print the header in any case, and allocate at least as 
> much space as is needed for the header. 
> This has two bad consequences:
> - - First, the actual description of short (up to ~1 hour in my hour size)
> the event description won't be printed, and instead the time will
> be shown (which is clear  from the timetable anyway). 
But with so less space only the first 3-4 letters of the description
would be printed, so it isn't usefull anyway... We should find a better
way to present the event description for short events.

> - - And second, zero-time events (Yes, people are really using them.
> There are
> at least 3 bug reports each with three or four duplicates about that!) and 
> very short events allocate at least the space needed for the header. If you 
> set the "Hour size in schedule view" to a rather small value, such zero-size 
> events will allocate 45 Minutes or more!!! 
?!? Wouldn't they do it with Tim's style?

> Another problem with your rounding of the events is that the radius of the 
> rounding is quite different for two identical events, one of which is the 
> only event at that time, while the other has other events at the same time 
> (so its width is smaller than the width of the first).
Yeah... painting the items next to each other is a bad idea IMHO anyway
because you'll have too less space for displaying the description again.
I'll check how iCal handels this next time...

> In my eyes, all events should have the same radius of the rounded corners, 
> otherwise it will probably look quite inconsistent.
Me too... but QPainter::drawRoundRect does not allow it ;)

> But then we have a problem with very short events, namely that quite a
> large percentage of the area will be lost to the corners.
Depends on the radius of the corner... with a radius of 15 the corner
looks round but doesn't take too much space.

> So, in short, I see some serious problems with your proposed patch, both 
> subjective (the look) as well as objective problems. 
> I'd like it much more if korganizers current look could be kept, and its 
> problems could be fixed.
Ok, thanks for the critic. I'll try o fix the technical issues and if
that's done we should ask the users which style they prefer, ok?

Ciao,
Tobias
-- 
Can a government that shoots at reporters be democratic?
Seperate politics from religion and economy!

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]