[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Kaddressbook: featurebarwidget
From:       Anders Lund <anders.lund () lund ! tdcadsl ! dk>
Date:       2002-11-30 21:39:04
[Download RAW message or body]

On Saturday 30 November 2002 13:29, Tobias Koenig wrote:

Hi Tobias,

> Fine. I would like to add a method ViewManager::addressBook(), so we can
> omit the first parameter in FeatureBarWidget and return
>   mViewManager->addressBook()
> in FeatureBarWidget::addressBook().
> So we can make the viewmanager to something like KMKernel in KMail, a
> central component that can provide all necessary stuff, that plugins would
> need to fulfil their task.

Yes, good idea :)

> > For the others, I'm not sure it is really nessecary, having this code in
> > show() and hide() is OK as long as those gets called [by the view
> > manager] when the display changes.
> >
> > I would like to change ViewManager::showFeatures( id ) though, since it
> > hide()s all feature bars. Why not just
> >
> >     if ( mCurrentFeatureBarWidget )
> >       mCurrentFeatureBarWidget->hide();
>
> Well... why not?
> Please commit :)

I'll fix and test that then, expect it comitted during sunday.

> It was late at night when I wrote this code, so maybe I didn't use the
> best concept...

/me is happy we are up to save CPU cycles, esp in such important places in the 
code :-)

-anders
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]