[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] PATCH: KDateEdit
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2002-11-17 9:00:35
[Download RAW message or body]

On Saturday 16 November 2002 21:37, David Jarvie wrote:
> Once KDateEdit arrow has been clicked to display the date picker
> popup, it currently remains showing the pressed state, and never
> reverts to the unpressed state. In some styles, this is very
> noticeable to the user, and is at odds with the behaviour of a normal
> combo box. Here is a patch to make it revert to the unpressed state
> after being clicked. I would like to see this go into KDE 3.1 if
> there is still time.
>
> Please review so that I can commit it.

This doesn't look right. listBox() can return 0, this will cause a crash 
with your patch. In addition to that passing a key_enter event when the 
enter key isn't pressed might cause problems. Is there no cleaner way 
to set the state of the arrow widget?

-- 
Cornelius Schumacher <schumacher@kde.org>
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]