[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] PATCH: KAddressbook resets default-filter for view when configuration is changed
From:       Tobias Koenig <tokoe () kde ! org>
Date:       2002-11-01 13:22:27
[Download RAW message or body]

On Tue, Oct 29, 2002 at 09:26:11PM +0100, Martin Thierer wrote:
Hi Martin,

> The attached patch fixes two little bugs in kaddressbook:
Sorry for the late reply, I was on a fair the last 3 days and had not
enough time for mail checking and coding.

> 1. If a default filter is set for a view the configuration-key isn't 
> correctly loaded in the view-configuration dialog. Therefore the filter 
> for this view is reset when the configuration is changed.
Yes, the code tested for
  config->hasKey("DefaultFilter")
but this key isn't used anywhere. I've sent a patch.

> 2. The combo-box for the filter-configuration in the view-configuration 
> dialog shows filter names with an "&" in them with two "&"s instead. 
> That's because the name is changed in "FilterDialog::setFilters" to 
> prevent KSelectAction from displaying a shortcut.
>
> Although I know that I'm to blame for this (as I bugged Tobias to do it 
> :-), I don't like this solution.
I tested the method you mentioned. It works quite well.
(See my second patch in list)

Thank you for the patch.

Ciao,
Tobias
-- 
In a world without walls and fences who
needs Windows and Gates???
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]