[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] KAddressBook doesn't compile
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2002-10-21 12:32:57
[Download RAW message or body]

On Monday 21 October 2002 13:46, Matthias Kalle Dalheimer wrote:
> On Monday 21 October 2002 13.38, Tobias Koenig wrote:
> > On Mon, Oct 21, 2002 at 07:33:02AM +0200, Matthias Kalle Dalheimer 
wrote:
> > > On Sunday 20 October 2002 23.29, Cornelius Schumacher wrote:
> > > > KAddressBook doesn't compile because of the removal of the
> > > > ldapotionswidget and the addhostdialog. Martin, could you fix
> > > > that as soon as possible, please?
> > > >
> > > > We are approaching a release, it's not acceptable to do commits
> > > > like that.
> > >
> > > Ahem, ldapoptionswidget.{cpp,h} and addhostdialog.{cpp,h} are
> > > generated files which should _never have been_ in CVS.
> >
> > They _were_ generated files. I'd handcoded them again to reduce
> > code and add some structural improvments.
>
> In that case, the .ui files shouldn't have been in CVS (and not in
> the makefile either).

The ui files have been removed a month ago, when Tobias converted the 
widgets from designer-generated to hand-written code. Apparently Martin 
committed to the wrong branch. That can happen, but what shouldn't 
happen is to committ something without doing "make" before. This would 
have avoided the trouble.

-- 
Cornelius Schumacher <schumacher@kde.org>
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]