[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] libkabc API problems
From:       Tobias Koenig <tokoe82 () yahoo ! de>
Date:       2002-09-29 12:10:33
[Download RAW message or body]

On Sun, Sep 29, 2002 at 03:23:49AM +0200, Cornelius Schumacher wrote:
Hi Cornelius,

> There are some small API problems in libkabc which come from changes 
> after the 3.0 relelase. As we can't fix them after we have released the 
> lib because of binary compatibility we have to resolve this now:
> 
> - AddressBook::saveAll() undermines the locking concept. I would like to 
> remove this function. It's the responsibility of the application to 
> ensure that all resources are saved.
Hmm, there was a reason for it but I can't remeber why I've added it.

> - AddressBook::resourceAddress() is in the wrong class. It doesn't 
> operate on the AddressBook but on the Resource, so I think it should be 
> part of Resource. I propose renaming it to Resource::takeAddressee().
No, it works on Addressee, so it should be
  void Addressee::changeResource( Resource* )

> - AddressBook::distributionListChanged() does not belong to AddressBook. 
> Distribution lists work on top of AddressBook. The AddressBook should 
> not depend on any distribution list classes. This code should probably 
> moved to the distribution list classes.
There was a bug report that complains about that some apps doesn't reload
there displays if the distribution list changed. I'll take a closer look at
it.

> - Where is AddressBook::lastAddressee() used? This is a strange 
> function. I don' think it should be part of the libkabc API. If an 
> aplication needs to store this kind of information I think it should do 
> it by itself.
I've used in in kcm_kabc, but the code has gone now. Will remove the method.

> I don't know what these changes would break, so could people using these 
> functions please comment, if the changes would cause problems?
I'll change it in the evening and test the other code.

Ciao,
Tobias
-- 
In a world without walls and fences who
needs Windows and Gates???
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]