[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: [Kde-pim] [PATCH] usability request
From: Tobias Koenig <tokoe () kde ! org>
Date: 2002-09-06 10:49:14
[Download RAW message or body]
Hi,
the attached patch add a 'Select All' and a 'Unselect All' button to
the ldapsearchdialog in KAddressBook. I think it's an improvment, since
only selected items can be applyed to the addressbook and selecting all
item manually isn't fun for large LDAP trees.
Can I commit it to CVS HEAD?
Ciao,
Tobias
--
In a world without walls and fences who
needs Windows and Gates???
["ldap.diff" (text/plain)]
Index: ldapsearchdialog.ui
===================================================================
RCS file: /home/kde/kdepim/kaddressbook/ldapsearchdialog.ui,v
retrieving revision 1.7
diff -u -b -p -r1.7 ldapsearchdialog.ui
--- ldapsearchdialog.ui 2002/08/09 11:19:30 1.7
+++ ldapsearchdialog.ui 2002/09/06 10:47:42
@@ -27,8 +27,8 @@
<rect>
<x>0</x>
<y>0</y>
- <width>530</width>
- <height>357</height>
+ <width>593</width>
+ <height>400</height>
</rect>
</property>
<property name="caption">
@@ -37,7 +37,7 @@
<property name="sizeGripEnabled">
<bool>true</bool>
</property>
- <vbox>
+ <grid>
<property name="name">
<cstring>unnamed</cstring>
</property>
@@ -47,7 +47,7 @@
<property name="spacing">
<number>6</number>
</property>
- <widget class="QGroupBox">
+ <widget class="QGroupBox" row="0" column="0">
<property name="name">
<cstring>GroupBox1</cstring>
</property>
@@ -171,13 +171,8 @@
</hbox>
</widget>
</vbox>
- </widget>
- <widget class="QListView">
- <property name="name">
- <cstring>resultListView</cstring>
- </property>
</widget>
- <widget class="QLayoutWidget">
+ <widget class="QLayoutWidget" row="2" column="0">
<property name="name">
<cstring>Layout5</cstring>
</property>
@@ -219,13 +214,46 @@
</property>
<property name="sizeHint">
<size>
- <width>20</width>
+ <width>40</width>
<height>0</height>
</size>
</property>
</spacer>
<widget class="QPushButton">
<property name="name">
+ <cstring>selectAllButton</cstring>
+ </property>
+ <property name="text">
+ <string>S&elect All</string>
+ </property>
+ </widget>
+ <widget class="QPushButton">
+ <property name="name">
+ <cstring>unselectAllButton</cstring>
+ </property>
+ <property name="text">
+ <string>&Unselect All</string>
+ </property>
+ </widget>
+ <spacer>
+ <property name="name">
+ <cstring>Spacer3_2</cstring>
+ </property>
+ <property name="orientation">
+ <enum>Horizontal</enum>
+ </property>
+ <property name="sizeType">
+ <enum>Expanding</enum>
+ </property>
+ <property name="sizeHint">
+ <size>
+ <width>30</width>
+ <height>0</height>
+ </size>
+ </property>
+ </spacer>
+ <widget class="QPushButton">
+ <property name="name">
<cstring>closeButton</cstring>
</property>
<property name="text">
@@ -234,7 +262,12 @@
</widget>
</hbox>
</widget>
- </vbox>
+ <widget class="QListView" row="1" column="0">
+ <property name="name">
+ <cstring>resultListView</cstring>
+ </property>
+ </widget>
+ </grid>
</widget>
<connections>
<connection>
Index: ldapsearchdialogimpl.cpp
===================================================================
RCS file: /home/kde/kdepim/kaddressbook/ldapsearchdialogimpl.cpp,v
retrieving revision 1.15
diff -u -b -p -r1.15 ldapsearchdialogimpl.cpp
--- ldapsearchdialogimpl.cpp 2002/08/22 13:27:35 1.15
+++ ldapsearchdialogimpl.cpp 2002/09/06 10:47:42
@@ -98,6 +98,10 @@ LDAPSearchDialogImpl::LDAPSearchDialogIm
this, SLOT( slotSetScope( bool ) ) );
connect( addSelectedButton, SIGNAL( clicked() ),
this, SLOT( slotAddSelectedContacts() ) );
+ connect( selectAllButton, SIGNAL( clicked() ),
+ this, SLOT( slotSelectAll() ) );
+ connect( unselectAllButton, SIGNAL( clicked() ),
+ this, SLOT( slotUnSelectAll() ) );
connect( mailToButton, SIGNAL( clicked() ),
this, SLOT( slotSendMail() ) );
connect( searchButton, SIGNAL( clicked() ),
@@ -340,4 +344,15 @@ void LDAPSearchDialogImpl::slotSendMail(
{
kapp->invokeMailer( selectedEMails(), "" );
}
+
+void LDAPSearchDialogImpl::slotSelectAll()
+{
+ resultListView->selectAll( true );
+}
+
+void LDAPSearchDialogImpl::slotUnSelectAll()
+{
+ resultListView->selectAll( false );
+}
+
#include "ldapsearchdialogimpl.moc"
Index: ldapsearchdialogimpl.h
===================================================================
RCS file: /home/kde/kdepim/kaddressbook/ldapsearchdialogimpl.h,v
retrieving revision 1.8
diff -u -b -p -r1.8 ldapsearchdialogimpl.h
--- ldapsearchdialogimpl.h 2002/08/22 13:27:35 1.8
+++ ldapsearchdialogimpl.h 2002/09/06 10:47:42
@@ -53,6 +53,8 @@ protected slots:
void slotAddSelectedContacts();
void slotSendMail();
void slotError( const QString& );
+ void slotSelectAll();
+ void slotUnSelectAll();
protected:
QString selectedEMails() const;
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic