[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] problem with name in libkabc
From:       Tobias Koenig <tokoe () kde ! org>
Date:       2002-09-05 21:50:25
[Download RAW message or body]

On Thu, Sep 05, 2002 at 10:49:36PM +0200, Cornelius Schumacher wrote:
> On Thursday 05 September 2002 18:19, Tobias Koenig wrote:
Hi,

> > I've changed the behaviour one day before the long time :)
> > In former versions realName() checked if formattedName() is empty,
> > and if that's not the case it returned the formatted name instead of
> > the joined name parts.
> 
> Ok. Then you have to change it back to the original behaviour. The 
> documented behaviour of realName() was to get the best possible name 
> representation and that's obviously a formatted name, if one is set, 
> because that exactly reflects how the user would like to see that name. 
> realName might not be the best name for this function, but it now has 
> this name and will keep it.
Did I already mentioned, that I hate
such 'for historical reasons' messed up code? ;)

> > Hmm, maybe we should introduce a method displayName() that returns
> > the formattedName() or if it's empty the realName(). So the
> > programmer don't have to care about if a formatted name is set when
> > he wants to display the name somewhere.
> 
> I would propose to introduce a function assembledName() which returns a 
> concatenation of the name parts. It shouldn't do anything different, 
> i.e. not fall back to name() or formattedName(), just put the name 
> parts together in a reasonable way.
Ok I've implemented the old behavior and port kaddressbook to working with it.
But atm I can't commit it to CVS until my previous patch (signal handler)
can be commited.

Ciao,
Tobias
-- 
In a world without walls and fences who
needs Windows and Gates???
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]