[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [another PATCH] Making KOrganizer/Part-type plugins selectable
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2002-08-30 12:33:50
[Download RAW message or body]

On Friday 30 August 2002 14:12, Best, Jan-Pascal van wrote:
> > > It also adds a dependency on the main
> > > window to the CalendarView. The better way would be to pass
> >
> > the main
> >
> > > window directly to the plugin configuration dialog.
> >
> > But how? The plugin conf. dialog is created (and owned) by the
> > KODialogManager, which is in turn created (and owned) by
> > CalendarView, so the only way the plugin dialog can learn which
> > main window it should operate on, is via CalendarView.
>
> *slaps himself in the face*
> What do we have the updateConfig signals for? It's all much easier
> that I thought. Please take a look at the attached patch. It removes
> all the cruft of passing on MainWindow* arguments, and lets the
> KOrganizer class reload its plugins in its updateConfig slot.
>
> What do you think of this?

Looks good now.

-- 
Cornelius Schumacher <schumacher@kde.org>

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]