[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] PATCHES for KDatePicker in kdelibs/kdeui
From:       Mike Pilone <mpilone () slac ! com>
Date:       2002-05-06 12:59:52
[Download RAW message or body]

This all look good to me. I don't have final say, so you should wait to here 
from Cornelius, but my vote is to apply them.

-mike

On Monday 06 May 2002 06:08 am, Arni Ingimundarson wrote:
> I first sent this to kde-devel but didn't get much responce, but
> someone sugested that you might be intrested.
>
> Regards,
> Arni
>
> ----------------------------------------
>
> Hello,
>
> I have been doing a little work on KDatePicker and attaced a patch
> with the changes I made.  My main goal was to fix (in my oppinion) a
> usability problem with the picker wenn QLineEdit has keyboard focus
> you cant use the arrow keys to change the date.
> I also did a little cleanup and simplified the code a bit.
>
> I have separated the changes into 5 files, so you can apply only some
> of these changes if you want.
>
> The changes in more detail:
>
> patch1: in the constructor KDatePicker I added table->setFocus() to
> 	ensure that the table widget has focus on startup (so you can
> 	directly use the arrowkeys to change the date).
>
> patch2: cleanups in the KDatePicker::month/year-forward/backward-clicked
> 	slots. QDate now has addYears, addMonths and addDays methods
> 	wich I use to make these slot implementations a one-liner.
>
> patch3: similar cleanups in KDateTable::keyPressEvent plus I changed
> 	the PgUp and PgDn keys to be able to scroll over year boundary.
> 	That revealed a small bug, that the year button didn't get
> 	updated (wich the patch also fixes).
>
> patch4: I also added a eventFilter on QLineEdit wich listens for few
> 	keys and then steels the focus (and gives it to the table).
> 	The keys it waits for are pgup, pgdn, up, down, + and - so
> 	you can still use left and right to edit the line.
>
> patch5: added support for + and - keys to incr/decr the date indefinitely
> 	and n selects the current date.
>
>
> I would like to hear your comments on these changes and if no one
> opposes I hope you apply some or all of these patches.
>
> I would realy like to have patches 2 and 3 accepted, because not to be
> able to change to/from des<->jan can be realy annoying.
>
> Best wishes,

-- 
Mike Pilone <mpilone@slac.com>        http://www.slac.com/mpilone/personal/
GPG Fingerprint = 856C 8B36 ECF7 9156 4611  7C6B C265 05C4 162F C3B5

See http://www.slac.com/mpilone/personal/mpilone_pub_key.gpg for full key.
See http://www.gnupg.org for GPG information.
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]