[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Scrollbars in KOrganizer Month View
From:       Joseph Manojlovich <josephm () mail ! sis ! pitt ! edu>
Date:       2002-04-28 8:03:54
[Download RAW message or body]

Hey everybody. Guess I'm just really bored tonight, so I've been going
back over some of the bug/wishlist reports that I've put in for
KOrganizer. I came across one about the scrollbars in the day cells of the
month view. 

Now, on a busy calendar like I have, many of the day cells get filled past
the borders of the cell. Right now, I can either let the text get cut off,
or have ugly scrollbars in many of the cells. I personally find the
scrollbars really distracting, and unnecessary as one can't possibly
scroll multiple days at the same time.

So I went and had a look inside the code. A few quick changes, and now the
scroll bars only show up when I click on a day that needs them. Click
anywhere else, and the scrollbars vanish. I personally find this much more
aesthetically pleasing, and more functional, as it does not hide the text
of unselected cells with unnecessary scrollbars, until you select them.

Here's a screenshot of the unpatched Korganizer:
http://www.cse.psu.edu/~manojlov/korganizer-bad.png

Here's a screenshot of Korganizer with this (and the previous) patch:
http://www.cse.psu.edu/~manojlov/korganizer.png

I naturally don't expect this or my other patch to be welcomed with opened
arms right into the code base. Rather, I'm just trying to point out what I
consider to be interface problems with Korganizer, and offering my own,
but I'm sure not the best, solutions to them.

Thanks!

--
Joe Manojlovich
josephm@sis.pitt.edu
"The trouble with the global village are all the global village idiots"
     Paul Ginsparg 


["korganizer2.diff" (TEXT/PLAIN)]

@@ -351,7 +347,8 @@
 
 void MonthViewCell::updateConfig()
 {
-  enableScrollBars( KOPrefs::instance()->mEnableMonthScroll );
+  //enableScrollBars( KOPrefs::instance()->mEnableMonthScroll );
+  enableScrollBars( false );
 
   setFont( KOPrefs::instance()->mMonthViewFont );
 
@@ -395,7 +392,7 @@
 {
   mItemList->clearSelection();
 
-  enableScrollBars( false );
+  if( KOPrefs::instance()->mEnableMonthScroll ) enableScrollBars( false );
 }
 
 void MonthViewCell::resizeEvent ( QResizeEvent * )
@@ -419,7 +416,7 @@
     emit newEventSignal( dt );
   }
 
-  enableScrollBars( true );
+  if( KOPrefs::instance()->mEnableMonthScroll ) enableScrollBars( true );
 }
 
 void MonthViewCell::contextMenu( QListBoxItem *item )

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]