[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Patch for alarm daemon
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2002-03-09 23:24:32
[Download RAW message or body]

On Wednesday 06 March 2002 19:51, David Jarvie wrote:
> Here is a small patch for the alarm daemon. Its purpose is to ensure
> that the time interval between the alarm daemon checking the alarm
> lists is no greater than the old or new check intervals set in the
> alarm daemon KControl dialog. Currently, if for example the check
> interval was 10 minutes and the user changed it to 9 minutes just
> before 10 minutes after the last alarm check, the total time between
> checks on that occasion would be 18 minutes - which is not what the
> user would expect. The patch also has specific implications for a
> KAlarm problem.
>
> Cornelius - could you review this please?

The patch looks fine. Calling checkAlarms should in no case cause a 
problem. Hmm, perhaps it does cause a problem, if it is called twice in 
the same second and there is an alarm scheduled for this second. 
Perhaps we should a check for this. But anyway, it's very unlikely, 
that this happens.

> ============================
> diff -u cvs/alarmdaemon.cpp alarmdaemon.cpp
> --- cvs/alarmdaemon.cpp  Mar  1 03:03:55 2002
> +++ alarmdaemon.cpp  Mar  6 18:22:25 2002
> @@ -302,6 +302,12 @@
>      mAlarmTimer->stop();
>      setTimerStatus();     // change the alarm timer's interval
>      notifyGui(CHANGE_STATUS);
> +    // The timer has been restarted, so check alarms now to avoid
> the interval
> +    // between the last and next checks being longer than either the
> old or +    // new check interval.
> +    // Do this AFTER notifying client applications about the change,
> in case +    // they need to take special action first.
> +    checkAlarms();
>    }
>  }
>
> ============================

-- 
Cornelius Schumacher <schumacher@kde.org>
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]