[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: PATCH: Addressee::isEmpty() (was: Re: [Kde-pim] kabc)
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2002-02-21 11:39:12
[Download RAW message or body]

On Thursday 21 February 2002 13:05, Mark Westcott wrote:
> On Thursday 21 February 2002 11:04 am, Cornelius Schumacher wrote:
> > On Thursday 21 February 2002 11:49, Mark Westcott wrote:
> > > On Thursday 21 February 2002 9:36 am, Cornelius Schumacher wrote:
> > > > On Thursday 21 February 2002 10:47, Mark Westcott wrote:
> > > > > I may be wrong here, but if isEmpty() is going to return  the value
> > > > > of bool mEmpty, and mEmpty is set to true in the copy constructor
> > > > > then isEmpty is going to return true even if an empty addressee is
> > > > > passed to the copy constructor, no?
> > > >
> > > > If you pass an empty addressee to the copy constructor you get an
> > > > empty addressee. That's perfectly right, isn't it?
> > >
> > > Yes, but how will mEmpty get set accordingly if we dont want to make it
> > > 'heavy' and go through checking all the fields?
> >
> > See the attached patch. Is this ok?
>
> Yep, looks fine.  My misunderstanding was thinking that mEmpty would be a
> private member variable of Addressee and not in AddresseeData.  I was just
> working on the same patch myself, you beat me to it :)
>
> Can you commit?

Done.

-- 
Cornelius Schumacher <schumacher.kde.org>
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]