[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] pilot-link and coldsync
From:       Adriaan de Groot <adridg () cs ! kun ! nl>
Date:       2002-01-27 18:21:10
[Download RAW message or body]

On Saturday 26 January 2002 23:05, Dag Nygren wrote:
> > But KPilotDeviceLink already *is* the abstracted device access class.
> > Well, that and PilotSerialDatabase. There's not much sense in abstracting
> > that any further.
>
> Perhaps not. I really have had just a glance at the stuff by now, but the
> if dlp_* is used in 4 files instead of one I think there is a need for some
> additional abstraction. In my mind the connection to the pilot should
> all be handled through one class/file. But I might be too idealistic ;-).

Well, sure. I just reduced it to 3 files, and the remaining calls are in 
hotSync.cc; they could be moved to something sufficiently abstract in 
KPilotDeviceLink as well. Seriously, I think that that class should serve as 
the C++ abstraction of the interface to the pilot device. It's really not 
*that* tied up with pilot-link.

Of the remaining dlp_ calls, one is dlp_WriteUserInfo and it really belongs 
in kpilotlink as well, since *reading* that information is done by that class 
internally at the beginning of a sync. And there's two calls to 
dlp_ReadDBList, which could become KPilotDeviceLink::getNextDatabase(), I 
suppose. Like I said before, if you need any changes to the API to make it 
fit better with ColdSync, just shout.

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]